signalapp / Signal-Desktop

A private messenger for Windows, macOS, and Linux.
https://signal.org/download
GNU Affero General Public License v3.0
14.62k stars 2.66k forks source link

Taskbar icon broke after update #4138

Closed Sityu91 closed 3 years ago

Sityu91 commented 4 years ago

Bug Description

I updated to v1.33.0 from the previous version yesterday and the taskbar icon broke (see screenshot). Restarting the computer didn't solve it.

Screenshots

signal

Platform Info

Signal Version: v1.33.0

Operating System: Windows 10

Linked Device Version: Android 9

Update (2020-04-14):

I have uninstalled and reinstalled since, the problem still remains. Can confirm the same pinning/unpinning behaviour as reported by @vertigo220 below.

tom-73bw commented 4 years ago

Same. Also wierd deformations here: 2020-04-08 09_38_38-

And here: 2020-04-08 09_40_08-Signal (1)

Platform Info

Signal Version: v1.33.0

Operating System: Win10 V 1909 Build 18363.657

Flupkees commented 4 years ago

For me too. Signal Version: v1.33.0 Operating System: Win10 Pro 1909 Build 18363.720

Same weird icon as Thomas. image

Other new logos look good though image

Furthermore, I can't send any messages anymore, but I'll make a seperate report for this

mMuck commented 4 years ago

The same ugly downsized logo for me too. Edit: Not a broken one as shown by @Sityu91 . Different problem?

@scottnonnenberg-signal I tried to find the exact commit where the logo changed, but I found only the png sources. What build step processes the icons and embeds them in the final win executable?

There are missing the bigger versions too - my win10 start menu icon in comparison: grafik

Perhaps it's a better idea to generate a optimized ico file with all important sizes and embed this to the exe?

https://github.com/signalapp/Signal-Desktop/blob/development/build/icon.ico uses the old logo. What is the purpose?

Thanks for the work on Signal-Desktop! 👍

vertigo220 commented 4 years ago

Just noticed this after updating to 1.33.0. Might have been there before, from other day's update, but don't think so. I know Signal recently changed their icon, so probably related. It's only there when pinned to the taskbar.

mackncheesiest commented 4 years ago

For me (Win10 Build 19033.1), I don't typically have Signal pinned to my taskbar, but I can make this artifact go away specifically by pinning and unpinning it.

vertigo220 commented 4 years ago

Yeah, but the problem is pinning it again makes it come back. But it is interesting that it's there when launched unpinned or pinned, but goes away when unpinning. So there seems to be something different about when that is done.

Sityu91 commented 4 years ago

I tried to reinstall, but the issue remains. I am fairly certain that my computer is not the culprit, no other apps since and before had this problem. So for the time being I reverted to the previous version. I wish it wouldn't pester me to let it update, though.

vertigo220 commented 4 years ago

Just updated and icon appears to be fixed.

josh-signal commented 4 years ago

Please update to v1.33.1

Sityu91 commented 4 years ago

It is fixed! Thank you very much!

mMuck commented 4 years ago

Updated to v1.33.1. Thanks. Taskbar icon fixed.

This was updated to the new one (old image):

grafik But stays small. Different issue I think and only cosmetics.

But this isn't fixed for me and stays ugly as @thomas-eickert posted (unchanged):

And here: 2020-04-08 09_40_08-Signal (1)

terenc3 commented 4 years ago

My taskbar icon still looks weird like @mMuck's window icon. Signal v1.34.0

kenpowers-signal commented 4 years ago

@terenc3 What version of windows are you on? Can you try removing the icon from your taskbar and re-adding it?

mMuck commented 4 years ago

My taskbar icon still looks weird like @mMuck's window icon. Signal v1.34.0

Just updated to v1.34.0. All icons still looks correct. Win10

ThaJay commented 3 years ago

I just updated Signal and now it has no taskbar icon any more

afbeelding afbeelding

EvanHahn-Signal commented 3 years ago

@ThaJay Sorry you're running into this. Are you using the production version or the beta version? And does it persist when you restart the app?

If you're not using the beta version, could you try joining it to see if you still experience the problem?

piotr-kasprzyk commented 3 years ago

I have the same problem (common file icon instead of a comic balloon) after current update. Version 1.40.0

AndreyNazarchuk commented 3 years ago

I just updated Signal and now it has no taskbar icon any more

afbeelding afbeelding

Same problem here, Also using dark mode. Happened after updating to 1.40.1 on the default channel

piotr-kasprzyk commented 3 years ago

It came back to normal next day - probably after the reboot.

Regards, Piotr

ThaJay commented 3 years ago

@EvanHahn-Signal It returned for me too today, like @piotr-kasprzyk .

EvanHahn-Signal commented 3 years ago

We think that this issue is caused once, when upgrading from a version prior to v1.40.0 (like v1.39.6) to a version after v1.40.0 (like v1.40.1). After that, the problem should not reappear. If you're seeing this issue, please reboot your machine and let us know if the problem ever comes back.

For some technical background: we use Electron Builder, which had this bug. It was fixed in https://github.com/electron-userland/electron-builder/pull/5312. We updated Electron Builder to get this fix in v1.40.0, which is why "crossing that gap" will cause an issue.

Though this is still a problem, there's not much we can do about it going forward unless it appears again. I'm going to close this issue. Let us know if it happens to you after rebooting or after another upgrade in the future.

Delurkdotcom commented 2 years ago

Greetings,

Same issue after the last Signal update, version 5.31.1 on Windows 11 taskbar. Nothing fixed after reebot. image

scottnonnenberg-signal commented 2 years ago

@Delurkdotcom What version did you upgrade from? A debug log (View -> Debug Log) would help us figure that out.

Delurkdotcom commented 2 years ago

Here the debug link: https://debuglogs.org/desktop/5.31.1/dc2a58c6a4aec934ac2456cec8f6d46b5b1e4bb46b38b2afbcb3f2c72662ab66.gz

scottnonnenberg-signal commented 2 years ago

Thanks for providing that debug log. Unfortunately it only goes back to 2022-02-13T12:48:49.507Z and it doesn't include the first start after installing the new version. Do you generally stay up to date? Install updates as soon as they come out?

Delurkdotcom commented 2 years ago

Yes. Today there is a new update that I applied. But, icon is always broken when I pin it. In an other hand, icon appear correctly when app isn't pinned.

biddgy commented 2 years ago

Yes. Today there is a new update that I applied. But, icon is always broken when I pin it. In an other hand, icon appear correctly when app isn't pinned.

100% this. Just installed desktop app (5.45.1 prod) after a fresh windows 11 install and when I pin to taskbar, get the window icon. Unpin it, back to normal. Nothing else wrong so no impacts, just annoyance.

indutny-signal commented 2 years ago

@biddgy I tried reproducing it, but unfortunately it appears to work correctly on my end. Does the taskbar icon break on updates? Could you try removing the Desktop icon and installing Signal again without uninstalling it, and then pin the icon again?

Thanks!

biddgy commented 2 years ago

Hi, I didn't have to install over it. I deleted the Desktop icon and then pinned the start menu icon to taskbar and that seemed to work. No issues.

indutny-signal commented 2 years ago

Awesome. Thanks for trying it out!

user4294 commented 1 year ago

I have the same issue - no task bar icon. It used to work when I didn't pin the icon, but now there's no icon even when using the exe. I tried running the setup again, without result.