search

signalapp / Signal-Desktop

A private messenger for Windows, macOS, and Linux.
https://signal.org/download
GNU Affero General Public License v3.0
14.49k stars 2.63k forks source link

Use proper font-family for each region (Chinese, Japanese, Korean) #4232

Open ghost opened 4 years ago

ghost commented 4 years ago

Many people in the East Asia region use Chinese characters. However, there are different types of Chinese characters, for example "traditional Chinese (Taiwan, Hong Kong, Macau)", "simplified Chinese (China mainland)", "kanji (Japan)", ("hanja (Korea)", "Chữ Nôm (Vietnam)"). NO NAME 001 (Please read CJK Unified Ideographs - Wikipedia for more details.) For that reason, application must use proper fonts for each region, but Signal Desktop uses only simplified Chinese fonts (CSS sets forcibly them).

~/stylesheets/_variables.scss: $inter: Inter, 'Helvetica Neue', 'Source Sans Pro', 'Source Han Sans SC', 'Source Han Sans CN', 'Hiragino Sans GB', 'Hiragino Kaku Gothic', 'Microsoft Yahei UI', Helvetica, Arial, sans-serif;

Source Han Sans SC, Source Han Sans CN, Hiragino Sans GB, Microsoft Yahei UI are for Chinese mainland fonts. Hiragino Kaku Gothic is for Japanese fonts (the font only included with macOS).

Platform Info

Signal Version: 1.13.4

Operating System: macOS (Windows)

ghost commented 4 years ago

Maybe #3606 is related to this issue.

riccoho commented 4 years ago

I also noticed the font is "standing out" from other Mac applications. In macOS there is a list of "Preferred Languages" to decide the order of preferred language (which affects the font to be used). In my Mac, PingFang HK should be used to display Chinese characters. However, Signal for Mac seems to be using Hiragino Sans GB instead. It would be nice if either Signal follows the system preference or it enables the selection of preferred font.

ivan commented 2 years ago

People who communicate in more than one language might also prefer to have per-conversation font settings.