signalapp / Signal-Desktop

A private messenger for Windows, macOS, and Linux.
https://signal.org/download
GNU Affero General Public License v3.0
14.51k stars 2.63k forks source link

Signal doesn't load the chat log for a contact if you switch to another conversation and after that you try to switch to the previous conversation while there's message awaiting to be sent #4364

Closed pkorba closed 3 years ago

pkorba commented 4 years ago

Bug Description

So I had a problem with DNS resolution on my machine which was caused by short outage of my DNS provider server. During that time I tried to send a message to my friend and message was stuck awaiting to be sent to the Signal server. While the message was pending, I switched to another conversation, and then I tried to return to the previous conversation in which there was this pending message. At this point Signal couldn't load the chat log. Part of window, where the chat log should be, was blank until the message was successfully delivered to the server or failed to be sent. This doesn't happen when you retry sending a message which initially failed to be sent. Switching between conversations works fine then. Problem only occurs if you switch between conversations while trying to send a message and before sending fails for the first time. I had no problem switching between other conversations when this happened.

Steps to Reproduce

  1. There's a problem connecting to the Signal server.
  2. Send a message.
  3. While message is is awaiting to be sent to the Signal server, switch to another conversation.
  4. While the message in the previous conversation is still awaiting to be sent, try to switch back to that conversation.

Actual Result:

Signal should display the chat log with your message awaiting to be sent.

Expected Result:

There's blank space where chat log should be. Chat log appears as soon as the message fails to be sent or successfully makes it to the Signal server.

Screenshots

On the screenshot you can see the moment when I tried to switch back to the conversation with my message awaiting to be sent and I'm greeted with a blank chat log. signal_bug_censored

Platform Info

Signal Version: Signal Desktop 1.34.2 (official deb package)

Operating System: Kubuntu 20.04 Kernel 5.4.0 I'm using DNS over TLS (stubby 1.5.1 configured to use dns1.nextdns.io on IPv4 network). I don't have IPv6 configured.

Link to Debug Log

https://debuglogs.org/bce407f1db3b230ea026910dc7c48efd59307d7c4e17a6e2d12c2fe09e591cda

hiqua commented 3 years ago

Seems fixed as of current beta.

EvanHahn-Signal commented 3 years ago

I just tried to reproduce this (and it sounds like @hiqua did too) and was unable to, so I'm going to close. Let me know if that's wrong and I can reopen.