Emoticons are spilt by line wraps

signalapp / Signal-Desktop

A private messenger for Windows, macOS, and Linux.

https://signal.org/download

GNU Affero General Public License v3.0

14.62k stars 2.66k forks source link

Emoticons are spilt by line wraps #4592

Open ProactiveServices opened 4 years ago

ProactiveServices commented 4 years ago

[x] I have searched open and closed issues for duplicates

Bug Description

Emoticons are split by line wrapping, which breaks up their visual effect.

Steps to Reproduce

Type a message long enough to be near a line break, then add an emoticon and send the message.

Actual Result:

Emoticon is broken across lines.

Expected Result:

Line break inserted before emoticon

Screenshots

Broken emoticon

Platform Info

Signal Version: 1.37.1-beta.2

Operating System: Kubuntu 20.04

EvanHahn-Signal commented 4 years ago

Thanks for filing.

I believe we're relying on the text wrapping that "comes with" Electron/Chromium, which probably doesn't do any special detection of emoticons like this. Are there other apps that do a better job with this?

ProactiveServices commented 4 years ago

None that I can think of immediately but I will keep an eye out for examples.

pgerber commented 4 years ago

Signal for Android is one of the apps that do a better job.