sticker preview blurry on certain video or High DPI configurations

signalapp / Signal-Desktop

A private messenger for Windows, macOS, and Linux.

https://signal.org/download

GNU Affero General Public License v3.0

14.63k stars 2.66k forks source link

sticker preview blurry on certain video or High DPI configurations #5058

Closed knarrff closed 3 years ago

knarrff commented 3 years ago

[x] I have searched open and closed issues for duplicates

Bug Description

The sticker selection/preview (when clicking the sticker icon right between the input field and the microphone icon) shows stickers blurry. They show fine after using within the communication context.

This is a recent regression.

Steps to Reproduce

click sticker-icon to open sticker-selection dialog

Actual Result:

blurry images

Expected Result: not-blurry images

Screenshots

Platform Info

Signal Version: 1.40.1

This was present already in 1.40.0, but is a regression from lot long before that (although I am not sure which version exactly).

Operating System: Debian Buster

Linked Device Version:

Link to Debug Log

hiqua commented 3 years ago

Screenshot? Debug log?

knarrff commented 3 years ago

https://debuglogs.org/8a8e3c71df0291392d73f571b864b8d8c77fefee0e85a2ff4b3a2e791bcba1f4

hiqua commented 3 years ago

Do you use HiDPI? Wayland? What's your hardware?

Possibly related:

knarrff commented 3 years ago

Indeed, this is connected to DPI settings, on a Lenovo Thinkpad T470p (currently on 1920x1200 external display, and with 2560x1440 internal display).

I am using xfce, and there the setting in

Settings Manager > Appearance > Settings > Fonts > DPI

changes how the icons, and in fact the whole signal content is scaled. What I wonder is: while disabling the DPI setting restores sharp sticker-previews, the stickers in the actual conversation are always sharp, regardless of the DPI setting, and they are also rescaled.

minosimo commented 3 years ago

Same issue for me I think, though I'm on windows with a 3440x1440 monitor with no resolution scaling.

https://debuglogs.org/c1928c0973fc478568ea9429734a77976ed3e68ba6002742b0673dfd8a1ec910

jacko0 commented 3 years ago

Same issue for me using Signal v1.40.1 on Linux Popos.

scottnonnenberg-signal commented 3 years ago

Is the emoji picker also blurry? How about when you click on your avatar in the top left? The difference between stickers in the conversation context and the popup appears to be the popup itself.

jacko0 commented 3 years ago

Is the emoji picker also blurry? How about when you click on your avatar in the top left? The difference between stickers in the conversation context and the popup appears to the the popup itself.

Hi Scott, strangely the emoji picker is ok, it's just the stickers. My avatar also seems ok. Once the stickers are in the message itself the sticker are no longer blurry.

minosimo commented 3 years ago

Emoji picker is ok. It's difficult to tell for sure, but I think the avatar is ok too.

ghost commented 3 years ago

This is also happening with the reaction viewer. I think I found the problem: Popper's "gpuAcceleration" uses translate3d instead of left and top placement.

transform

left+top

I'm no react, typescript, electron dev, so if there's one here, I think the relevant line is https://github.com/signalapp/Signal-Desktop/blob/3324563762046e97f49c4596ae30a48b5febac51/ts/components/conversation/Message.tsx#L1916 .

Maybe it should be <Popper placement={popperPlacement} gpuAcceleration=false> ?

scottnonnenberg-signal commented 3 years ago

@LoveIsGrief Thanks for that deep research!

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] commented 3 years ago

This issue has been closed due to inactivity.