signalapp / Signal-Desktop

A private messenger for Windows, macOS, and Linux.
https://signal.org/download
GNU Affero General Public License v3.0
14.6k stars 2.66k forks source link

v5.0.0-beta.0 (Windows) crash on "clear datas" option #5117

Closed BarbossHack closed 3 years ago

BarbossHack commented 3 years ago

Bug Description

The Signal Beta app crash when I try to use the option "delete datas" (or "clear all datas" I don't know, I have the french version "Suppression des données")

Steps to Reproduce

  1. Click on "Files"
  2. Click on "Preferences"
  3. Click on "Clear all datas"

Actual Result:

  1. The app close. But not in the background, I can still see the proccess "Signal Beta.exe" in the tasks, but the UI was closed and did not re-open itself.
  2. We can't directly manually re-open the app, because we will have an error (see screenshot below) so we have to kill the process and start again.
  3. I can't open the log file while the process is still up, and when I kill it, the log file is removed, so I can't give you logs of the crashes... But I can give you the log that I have "after" killing the process and re-open it again, we can still see some errors in it (see link below).
  4. The messages and discussion etc are actually NOT deleted (after the crash when I re-open the app, I can see everything), so this options does not work at all (for this beta release only)

Expected Result:

The app should close, delete datas, and re-open again (like before).

Screenshots

2021-03-20_10h35m42s

Platform Info

Signal Version: 5.0.0-beta.0

Operating System: Windows 10 64bit

Linked Device Version: iOS 5.8.0.22

Link to Debug Log

https://zerobin.net/?86e9a57e9e04f0bc#J470s6JaHz1WLQCXDdeb1djp3FEY6EE6m9EYmJ4Hli= (debug log leaked my user name so I [REDACTED] them and used zerobin.net for sharing)

BarbossHack commented 3 years ago

I forgot to add that after re-opening the app, I have the message "Not linked" which ask me to link again the Signal Desktop app, but I can still see all messages

josh-signal commented 3 years ago

Thanks for reporting we'll have a fix for this in the next release.

BarbossHack commented 3 years ago

I just updated from v5.0.0-beta.0 to v5.0.0-beta.1 through the update notification on the app.

The bugs I reported seems to have been fixed, thank you !

But there is a new one^^ Now when I try to "clear datas", the desktop app stucks on this screen : 2021-03-31_09h24m49s

After 10 minutes, I closed the app (because it was still stuck), re-opened it, and it was ok, everything was deleted (I assume) and I saw the "Qrcode screen" (so, normal behavior). But then I did NOT re-connect and clicked again on "clear data" (even if there was no data to clear), the app was again stuck on this screen...

Here is the log report of when the datas were cleared and I just reopened the app: https://zerobin.net/?86bc9d9de1946b5e#/PaUfZIoMFshj7AJXacYew2jL2ci0ldEw6FNDTyQvX= (unhandled promise rejection: HTTPError)

Thank you for your work 👍

josh-signal commented 3 years ago

@BarbossHack are those the only logs you have? The 401 is normal when you have an unlinked desktop.

BarbossHack commented 3 years ago

@BarbossHack are those the only logs you have? The 401 is normal when you have an unlinked desktop.

Unfortunately, these are the only logs I have... because when I click on "Clear data" the logs are also cleared. Maybe there is an other way to get the logs than the log file, if I try to run the exe from cmd will I see the logs in the output ? (Currently I'm not at home to test that)

(ok for the 401)

BarbossHack commented 3 years ago

I confirm I can't have more logs, they are deleted and there is nothing interesting in cmd output

EvanHahn-Signal commented 3 years ago

We believe we've fixed this issue—thanks for making sure it was a beta-only bug. Closing.

BarbossHack commented 3 years ago

@EvanHahn-Signal @josh-signal this issue is not fully fixed. The app still stuck on the "disconnect and delete data" screen https://github.com/signalapp/Signal-Desktop/issues/5117#issuecomment-810860613

Or it should be in a new issue ?

EvanHahn-Signal commented 3 years ago

@BarbossHack Would you mind creating a new issue? It's a little easier for us if we have one problem per issue, which wasn't the case here. Thanks!