Pinned conversation are unpinned after first sync

BarbossHack commented 3 years ago

[x] I have searched open and closed issues for duplicates

This is a duplicate of https://github.com/signalapp/Signal-Desktop/issues/4838 , but he give 2 errors in his issue, it would be easier to track with only one error (and I give more details, and logs).

Bug Description

When I link the desktop app to my iOS device, my 3 pinned conversations are unpinned for both sides (desktop and iOS), but not every times : somes times the pinned conversations are synced with success in desktop app and not removed from iOS app.

This is not related to v5.0.0-beta.2 or else, I had this error since v5.0.0-beta.0 I think, but maybe before...

Steps to Reproduce

Open the desktop app
Scan the QRcode with the iOS app
Wait somes minutes that syncing is finished for sure

Actual Result:

Some times, pinned conversations are unpinned for both sides.

Expected Result:

Pinned conversations are showing after sync.

Screenshots

None

Platform Info

Signal Version: v5.0.0-beta.2

Operating System: Windows 10 64 bit

Linked Device Version: iOS14.4.2 - Signal v5.8.10

Link to Debug Log

These are both sides logs from when my 3 pinned conversations were unpinned

Desktop app: https://zerobin.net/?91c445a0c7431915#3wsMtTWfRnQJbf2Soq4rJtWChlJxI1O0xk29n8kku1= iOS app: https://zerobin.net/?baba47ba8caeb5eb#bCGAOz9S7ucLCv9JKJX1Yggl6eU4xuiemoIm/AiXpl=

josh-signal commented 3 years ago

@BarbossHack just to get some clarity here, you have 3 conversations pinned on iOS and you link your blank desktop to it. You expect to see the same 3 pinned conversations on desktop but they are not pinned. You check iOS and the conversations are not pinned there either after linking your desktop.

BarbossHack commented 3 years ago

@BarbossHack just to get some clarity here, you have 3 conversations pinned on iOS and you link your blank desktop to it. You expect to see the same 3 pinned conversations on desktop but they are not pinned. You check iOS and the conversations are not pinned there either after linking your desktop.

Exactly !

josh-signal commented 3 years ago

@BarbossHack are there perhaps more logs related that are not being included? I see that there was a storage sync for manifest version 8206 but only 1 item was synced, not 3.

BarbossHack commented 3 years ago

Sorry @josh-signal but since last time I unlinked my desktop app and disabled my iOS logs

But I made the steps again, and I waited longer at the end of the sync process, and closed / opened again both iOS and desktop apps (to be sure that logs were complete on both sides), and here they are :

Desktop: https://zerobin.net/?6273b99b5b673b9e#ahuxifXx6ojkKnpxl6wxd9QH3kA1Jy7Ake9Pj+CzAA= iOS: https://zerobin.net/?03e96ed9647ce3b3#PcGbki2oNcAC1QuFm1b7G4+qSX5nsRTKRCqNOBZ2kO=

If you need more feel free to ask

(EDIT: like the first time, my 3 iOS pinned conversations were unpinned from iOS (and not pinned in desktop), so same behavior)

josh-signal commented 3 years ago

@BarbossHack thanks for the report, we should have a fix for this in the next release.

BarbossHack commented 3 years ago

@josh-signal I can confirm that it has been fixed in v5.0.0-beta.3

Thank you !

Additionnaly, I tried to unlink / link the desktop too many times (~5 times) and I got temporarily blocked haha And after waiting a few minutes, when I tried to link again I got a "Failed to retrieve new device keys for identifier" with http 413 (Payload Too Large) in logs, and failed to link https://zerobin.net/?38c469a61d4a359b#7srFS/tEJJKpi7+QLUnNGP8xY/TGyKLgeHa4IORnY/=

Anyway, I just linked again and it worked, with all conversations pinned 👍

EvanHahn-Signal commented 3 years ago

I'm going to close this issue because I think this is resolved. Thanks for your help!

Le1b1 commented 3 years ago

I'm facing the exact same issue, please reopen.

Desktop: https://debuglogs.org/e481a0e9191573add82f61da74612662a33cad3cf17b666c3884477a18a80b9d.gz Android: https://debuglogs.org/4b0d948c08199e9f1850d6f2224cd86afa957575d448b677c7ebf1bfc07781c4

BarbossHack commented 3 years ago

Works fine on my side (if it can help to find the bug)

Desktop: v5.17.2 iOS: v5.20.1.3

hiqua commented 3 years ago

@Le1b1 how do you reproduce the issue exactly?

Le1b1 commented 3 years ago

@hiqua Just link the Desktop client and wait

EvanHahn-Signal commented 3 years ago

I just tried to reproduce this issue and pinned conversations showed up just fine when I linked. Please let us know if the problem persists for you and we can investigate.

Le1b1 commented 2 years ago

Not sure how much time you @EvanHahn-Signal wanna dedicate to his. 😃 I'm linking and unlinking one of my clients on a daily bases. About half of the time I'm experiencing one or more of these problems:

Chats unpinned (also on main device)
Only some of the memberships of a contact in a group shown in their profile
Default disappearing messages timer setting set from '4 weeks' to 'Off' (also on main device)
Verified contact is declared unverified and verified again on main device
Desktop will set a disappearing messages timer in a (on the main device) existing conversion if I don't sent a message at first on the main device

I can't reproduce any of it reliably, but it happens. Please let me know if i can help debugging it.

scottnonnenberg-signal commented 2 years ago

@Le1b1 After it happens, please provide a debug log from all of your devices - primary, the one just linked, and your others. That will give us enough information to track it down. Thanks!

Le1b1 commented 2 years ago

Linked the Desktop client again this morning. Received a message from a pinned, verified contact (first message in that conversation) :

Bug 1: A group is missing in the "Member of ...." section. Bug 2: Contact is marked as unverified (also on main device) Inked2021-11-17 08_33_47-Signal Beta_LI

Newly linked Desktop client: https://debuglogs.org/f79337781c8859805d21b1a5832d6be73325fa1660805d6af3d4b94b9fb0e757.gz Primary: https://debuglogs.org/3ced09e5dda582680edebffab67077e887cd7e8cf094752c340b8ba5ad697425 There is a second desktop client linked, but it wasn't on at the time.

indutny-signal commented 2 years ago

@Le1b1 thanks for this report. Did it happen to just a single contact?

Le1b1 commented 2 years ago

@indutny-signal No, but I didn't search for other contacts with problems. Will investigate next time, too.

indutny-signal commented 2 years ago

No problem, I think we have some important clues to figuring it out already. Thanks for your information!

Le1b1 commented 2 years ago

So I'll sit back and wait? 😃

indutny-signal commented 2 years ago

That's one way to say it :joy: If you'll run into it more - please feel free to submit debug logs here! We'll look into the issue soon.

Le1b1 commented 2 years ago

And again, linked the new desktop then did a Beta update:

Chats unpinned (also on main device)
Only some of the memberships of a contact in a group shown in their profile
Default disappearing messages timer setting set from '4 weeks' to 'Off' (also on main device)
New: Got a message request for my pinned contact after their first message

Desktop: https://debuglogs.org/cccc113bfbdf2f5048b21ee2011a5f92420c010f122757ff334572975f74ac68.gz Android: https://debuglogs.org/82bb9c12623a4c840b9e3b7147342375907d02baa1510dc72ab1a92497e5359f

Le1b1 commented 2 years ago

Another one: Desktop: https://debuglogs.org/93089c625d86528397a38783b11e7845c942fbfd6a632d3f7fbfb7915f6d85a3.gz Android: https://debuglogs.org/85b47d3847f552cd15843fa03786c2713dad7f39c5d02f94d11cf04dd546bad7

Le1b1 commented 2 years ago

Only some of the memberships of a contact in a group shown in their profile

Desktop will set a disappearing messages timer in a (on the main device) existing conversion if I don't sent a message at first on the main device

This is still the case in the latest Beta. Do you still track this, @indutny-signal ? Anything I can help with on my side?

scottnonnenberg-signal commented 2 years ago

@Le1b1

Only some of the memberships of a contact in a group shown in their profile

Is this the list shown in the contact popup? That's at most three, so it will exclude other groups you have in common.

Desktop will set a disappearing messages timer in a (on the main device) existing conversion if I don't sent a message at first on the main device

Can you provide a little more information about this? Are you talking about the new global disappearing messages setting in Preferences > Privacy?

Le1b1 commented 2 years ago

Screenshot from a recently linked Desktop client to make it clearer

Is this the list shown in the contact popup?

Not sure to which popup you're referring to. I have 3 groups in common with this contact, only one is mentioned.

Can you provide a little more information about this?

Sure

Global disappearing messages setting is set to '4 weeks'
There is a existing conversation with that contact on the main device, but disappearing messages are disabled for that conversation
Add a new Desktop client
Sending a message to that contact from the new Desktop client will enable disappearing messages. This is not what I want, but to be fair, Desktop informs me about the fact ('The disappearing message time....'). But: In the disappearing messages setting for that contact, the setting is show as 'off'.
If I send a message to that contact from my main device or receive a message from that contact, Desktop client will not set disappearing messages for that contact. Perfect!

To make it short: The disappearing messages settings for 1on1 conversations are only respected by a newly linked Desktop client if a messages has been received before I send one. Otherwise global setting will override existing disappearing messages settings for that chats.

Hope this helps.

Le1b1 commented 2 years ago

Update:

Is this the list shown in the contact popup?

Not sure to which popup you're referring to. I have 3 groups in common with this contact, only one is mentioned.

The two groups that are missing her are also not in the list of groups if a wanna start a 'New conversation'. Maybe that is the underlying reason?

These groups and theire messages aren't shown at all, even if I sent messages to them from my main device. Debug log: https://debuglogs.org/desktop/5.33.0-beta.1/51aac59765a96dd092dfab9df46eef8450a5e6d9e8973f754e33a666aa731c43.gz

EvanHahn-Signal commented 2 years ago

@Le1b1 Sorry you're seeing this. To help us understand your log: can you find some message sent timestamps (they look like 1645107783828) that didn't cause your Desktop to pop them into the conversation list? We're trying to figure out if the messages were never sent to Desktop, or if Desktop got them but ignored them.

Le1b1 commented 2 years ago

@EvanHahn-Signal I couldn't manage to find a message with a timestamp around the one you mentioned. But here is an update regarding this matter:

These groups and theire messages aren't shown at all, even if I sent messages to them from my main device. Approximately an hour after I sent the message to hat group it did show up on Desktop, starting with: All the subsequent messages where there, including the correct time and date. https://debuglogs.org/desktop/5.33.0-beta.1/49d953654c97133ab941ca308bb0018a29150a49afc4537833d751271dd44ca0.gz The first of these messages (sent from my primary device) is timestamp 1645104583359. Hope this helps.

Le1b1 commented 2 years ago

Pinned chats not synced in latest Desktop Beta, this time they are still pinned on Android. CC @EvanHahn-Signal Desktop: https://debuglogs.org/desktop/5.39.0-beta.1/0dd8093123c4ba0d671d066933397c7534bb300d12735f1fcc1c9f039e951c66.gz Android: https://debuglogs.org/android/5.35.1/2eac257f81c8c6ea89156ff9ca018c72277ca8c41bd06117033e23cb8a286b8c

indutny-signal commented 2 years ago

Sorry about that. I see the relevant error in the log and we will get it fixed soon.

indutny-signal commented 2 years ago

@Le1b1 could you try the 5.40.0-beta.1, please? I made a fix that hopefully should make things better for you!

Le1b1 commented 2 years ago

@indutny-signal Yes, it works, but feels slow and often it shows network issues when opened from the tray https://debuglogs.org/desktop/5.40.0-beta.1/0b5dc2cf9f9309cb27844f7c469f420dd1956ae3771062baaa38a1a00da2f6cd.gz

signalapp / Signal-Desktop