signalapp / Signal-Desktop

A private messenger for Windows, macOS, and Linux.
https://signal.org/download
GNU Affero General Public License v3.0
14.7k stars 2.69k forks source link

When forwarding a message, the emoji selector isn't scrollable if it is overflowing the modal #5259

Open azuredusk10 opened 3 years ago

azuredusk10 commented 3 years ago

Bug Description

Steps to Reproduce

  1. Click on "forward message" on any message
  2. Select a recipient
  3. In the message box, type in a colon :
  4. Type in a generic emoji query, such as :sm
  5. Try scrolling through the drop-down list of emojis

Actual Result:

The drop-down list of emojis can't be scrolled, even though the full list isn't visible on the screen.

Expected Result:

The list can be scrolled to view all of the eomjis present in the drop-down menu

Screenshots

Screenshot 2021-05-14 at 10 49 10

Platform Info

Signal Version: 5.1.0

Operating System: MacOS 11.2.3

Linked Device Version: iOS v5.12.0.52

Link to Debug Log

hiqua commented 3 years ago

It was not clear to me what you meant initially, so to save others 2min: the emoji query returns 10 results from :em, but on the screenshot there are only 5 results visible, and 5 others are not. The results should be scrollable so that the user knows which emoji is currently selected (before choosing to insert it in the message).

For instance, the 6th result from :em: is :no_smoking:, but the user does not know whether it's being selected or not.

More generally: we could have way more results, (say 100), make the results scrollable in any case, and show a number of emoji proportional to the available size on the screen. 10 is rather small on a big screen for a user trying to find new emojis, but as OP showed it can also be too many in a smaller window.

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

hiqua commented 3 years ago

Current.