search

signalapp / Signal-Desktop

A private messenger for Windows, macOS, and Linux.
https://signal.org/download
GNU Affero General Public License v3.0
14.55k stars 2.64k forks source link

Stop screen share button doesn't fit, scroll bar appears #5330

Open Meteor0id opened 3 years ago

Meteor0id commented 3 years ago

Bug Description

In the Dutch localization of Signal Desktop the "stop screen share" button takes up more space, and Signal handles this by adding a scroll bar. There are better ways to handle this, such as widening the button, reducing the font size, or reducing the padding around the text.

Steps to Reproduce

  1. step one
  2. step two
  3. step three

Actual Result:

Expected Result:

Screenshots

Platform Info

Signal Version:

Operating System:

Linked Device Version:

Link to Debug Log

EvanHahn-Signal commented 3 years ago

Sorry you're running into this. Could you share a screenshot?

Meteor0id commented 3 years ago

It's still completely functional, but it just looks off and could be handled a little better.

Signal stop screen share Dutch

Meteor0id commented 3 years ago

doestnt fit signal

Wouldn't say it got better ... Now the text is way too short to understand what it says. Even if I shorten the translation this will be too small. If I only make it say "stop" it may seem like the call it self was stopped instead of just the screen sharing.

Meteor0id commented 3 years ago

I've rephrased both strings so it can make sense (the button now just says stop) But the result is that there is little space for the window name.