Emoticons cannot be inserted by pressing 'Enter'

rik-smeets commented 3 years ago

[X] I have searched open and closed issues for duplicates

Emoticons cannot be entered into a message by pressing 'Enter' on the keyboard. This is an accessibility bug, since buttons should be accessible both with 'Space' and 'Enter'.

Bug Description

Steps to Reproduce

Open the emoji picker with the keyboard (Shift + Tab if keyboard focus is on the message input)

Actual Result:

Keyboard focus is not visible and not on a logical element.
When you select an emoticon and hit 'Enter', the emoji picker closes without inserting the emoji into the message.

Expected Result:

Keyboard focus is visible and on a logical element
Selecting an emoticon with 'Enter', inserts the emoticon into the message.

Platform Info

Signal Version: 5.11 Operating System: Windows 10* 64-bit

hiqua commented 3 years ago

I agree that Enter should select the emoji, but to be clear, you can already select an emoji with Space.

rik-smeets commented 3 years ago

I agree that Enter should select the emoji, but to be clear, you can already select an emoji with Space.

Thanks for letting me know, I totally missed that! I'm used to hitting 'Enter' to select buttons. I updated the issue description.

KeronCyst commented 2 years ago

It looks like this was fixed for the quick reactions, but not yet for the full emoji chart.

We like our keyboards!

hiqua commented 2 years ago

Enter works for me now.

rik-smeets commented 2 years ago

It still doesn't for me; it just sends the message that already has been typed in the input.

hiqua commented 2 years ago

Ah yes it only works for reactions, not for message emojis.

signalapp / Signal-Desktop