signalapp / Signal-Desktop

A private messenger for Windows, macOS, and Linux.
https://signal.org/download
GNU Affero General Public License v3.0
14.6k stars 2.66k forks source link

When using the emoji-picker and write some Text, the first character gets lost #5451

Open BOFH90 opened 3 years ago

BOFH90 commented 3 years ago

related to the closed #4708


Bug Description

In Signal-Desktop 5.12.2 (Linux and Windows) when opening the emoji-picker and selecting a emoji, the first non-space character closes the panel and only the second character onwards get sent to the input field.

Steps to Reproduce

  1. Write some message
  2. Open the emoji picker
  3. Select an emoji with a left click
  4. The picker stays open after selecting one
  5. Type some characters and the first one will be missing/lost

Platform Info

Signal Version: v5.12.2

Operating System: Windows 10

Linked Device Version: 5.19.4

SeriousMatters commented 3 years ago

I tested some key presses while emoji panel is open and has focus (clicked on).

List of unexpected behaviours, imo

key: alphanumerics / symbols current behaviour: first character not sent to input field, emoji panel closes suggested behaviour: first character is also sent to input field, emoji panel closes rationale: user expect all key presses are sent to input field

key: back space / delete current behaviour: character deleted, emoji panel closes suggested behaviour: character deleted, emoji panel stays open rationale: user may want to delete emoji(s) then click on another emoji to replace it

key: home / end / page up / page down current behaviour: cursor not moved, emoji panel closes suggested behaviour: cursor moved, emoji panel stays open rationale: should behave the same as arrow keys. user may want to continue adding more emoji at different positions.

key: shift + enter current behaviour: newline sent to input field, emoji panel closes suggested behaviour: newline sent to input field, emoji panel stays open rationale: adding newline should behave the same as adding space

key: caps lock / num lock current behaviour: locks mode changes, emoji panel closes suggested behaviour: locks mode changes, emoji panel stays open rationale: changing lock mode should not affect emoji panel?

List of correct behaviour, imo

key: spacebar current behaviour: space sent to input field, emoji panel stays open

key: arrow keys current behaviour: cursor moves, emoji panel stays open

Edit: formatting

mapelpapel commented 3 years ago

Please fix this, it's quite annoying