signalapp / Signal-Desktop

A private messenger for Windows, macOS, and Linux.
https://signal.org/download
GNU Affero General Public License v3.0
14.51k stars 2.63k forks source link

signal windows app uses wmic declared as obselete by microsoft #5658

Open cgrazy opened 2 years ago

cgrazy commented 2 years ago

patches\os-locale+3.0.1 uses a call to wmic

function getWinLocale() {

wmic has been declared as obsolete by microsoft in win10 The WMI command-line (WMIC) utility is deprecated as of Windows 10, version 21H1, and as of the 21H1 semi-annual channel release of Windows Server. This utility is superseded by Windows PowerShell for WMI (see Chapter 7—Working with WMI). This deprecation applies only to the WMI command-line (WMIC) utility; Windows Management Instrumentation (WMI) itself is not affected. Also see Windows 10 features we're no longer developing.

https://docs.microsoft.com/en-us/windows/win32/wmisdk/wmic

josh-signal commented 2 years ago

I checked os-locale and they're still using wmic on their latest version. Mind opening this issue there and linking it here? https://github.com/sindresorhus/os-locale