search

signalapp / Signal-Desktop

A private messenger for Windows, macOS, and Linux.
https://signal.org/download
GNU Affero General Public License v3.0
14.62k stars 2.66k forks source link

Signal desktop does not -release- audio playback shortcut after listening to voice memos #5699

Closed vastiditycoding closed 2 years ago

vastiditycoding commented 2 years ago

Bug Description

Signal desktop on Windows 10 does not "release" audio playback to keyboard or mouse audio shortcuts after listening to voice memos. If for example you are listening to music in Spotify and hitting the physical media shortcut key (Play/Pause) on Keyboard or mouse... all is well, but if you click on and play a voice memo in Signal, the physical media shortcut key (Play/Pause) on Keyboard or mouse is indefinitely stuck to play the same voice memo in Signal even if Signal is minimized and Spotify or YouTube is open in Firefox or a media player application like VLC or Media Player Classic is in use.

The only way to release it is to close Signal and open it again, then all other applications behave correctly. The problem happens all over again the moment a voice memo is played inside of Signal.

Issue has been present for roughly about a month or so.

Steps to Reproduce

  1. step one - Play music or video media in an application using a physical media shortcut key (Play/Pause) on Keyboard or mouse
  2. step two - Play a voice memo in Signal
  3. step three - Minimize Signal and switch to another music or video playback application and try to use the physical media shortcut key (Play/Pause) on Keyboard or mouse

Actual Result:

Expected Result:

Screenshots

Platform Info

Signal Version: 5.26.1 (Production)

Operating System: Windows 10 version 21H1 (OS Build 19043.1415)

Linked Device Version: 5.28.5 (Android 10)

Link to Debug Log

https://debuglogs.org/c37c55e7fb12624cd756584dbb9633f53a10709ea4d4299abda89aa5a6703507.gz

In most cases, a log from your other devices is also useful: Android: https://support.signal.org/hc/en-us/articles/360007318591#android_debug iOS: https://support.signal.org/hc/en-us/articles/360007318591#ios_debug -->

samsapti commented 2 years ago

Yea, I've got the same issue. It's probably because Signal implements the MPRIS interface specification (which is what allows it to be controlled by the media playback keys), just like any other media player or web browser, and AFAIK MPRIS-enabled players are only unregistered as a player when they're shut down. Tbh, I can't see why Signal needs to have that, but I think it's an upstream Electron thing that they just haven't bothered to (or can't, idk) get rid of in Signal.

Pro tip: playerctl allows you to see and control active players.

jessicarod7 commented 2 years ago

Seems to be related to #4939, but I've also had the same issue since I started using the desktop app a year ago.

vastiditycoding commented 2 years ago

Oh wow, I wish I would have caught/seen issue #4939 before I made mine. I guess I did not search deep enough or use the right terms. But yes, reading others replies in '4939' it seems many are affected by it.

scottnonnenberg-signal commented 2 years ago

Closing this in favor of https://github.com/signalapp/Signal-Desktop/issues/4939