signalapp / Signal-Desktop

A private messenger for Windows, macOS, and Linux.
https://signal.org/download
GNU Affero General Public License v3.0
14.7k stars 2.68k forks source link

Get tests running in a headless browser on travis #57

Closed liliakai closed 10 years ago

liliakai commented 10 years ago

with mocha-phantomjs, we get failures when trying to use some modern (though not-yet official/standard) browser features, e.g.:

ReferenceError: Can't find variable: Promise

and

TypeError: '[object Uint8Array]' is not a valid argument for 'Function.prototype.apply'
arlolra commented 10 years ago

There's no timeline for a phantomjs 2 release.

Would you consider using Sauce Labs? It's free for open source. https://saucelabs.com/opensauce https://saucelabs.com/javascript/mocha-js

liliakai commented 10 years ago

:+1: Sauce Labs, with the caveat that some of our tests currently depend on the native client module, which isn't supported by selenium chrome driver.