signalapp / Signal-Desktop

A private messenger for Windows, macOS, and Linux.
https://signal.org/download
GNU Affero General Public License v3.0
14.55k stars 2.64k forks source link

[Safari] When I copy an image, its address is copied to the message #5748

Open simonf-dev opened 2 years ago

simonf-dev commented 2 years ago

Bug Description

When I copy a picture from a website and paste it to Signal chat, an url of the picture pastes too. Then I have to delete the url of the picture manually. It's also reproducible with images from a localhost. The path from the Filesystem is copied instead of the web address.

Steps to Reproduce

  1. Open Signal app -> Open a chat
  2. Find a random picture on Google -> Right click to the picture -> Copy image
  3. Past the image to the chat

Actual Result:

Url of the picture pastes to the message.

Expected Result:

Url of the picture doesn't paste to the message.

Screenshots

image

Platform Info

Signal Version: 5.28.0 production (Intel)

Operating System: macOS Big Sur 11.6

Linked Device Version: iOS 5.26.9

Link to Debug Log

None

josh-signal commented 2 years ago

What browser are you using to copy the images?

simonf-dev commented 2 years ago

Safari 15.0

josh-signal commented 2 years ago

I'm thinking we'll need an electron change here but I'll put this on our radar in case we can patch it soon.

theankush commented 1 month ago

The same issue is happening in the latest version on Android device. The browser is Chrome

scottnonnenberg-signal commented 1 month ago

@theankush For Android issues, you'll want to create an issue here: https://github.com/signalapp/Signal-Android/issues

I'm going to close this, as it appears to be fixed for Desktop.

qerub commented 4 weeks ago

I can still reproduce this with Signal 7.22.2 and Safari 17.5. @simonf-dev: How about you?

ayumi-signal commented 3 weeks ago

I can confirm this issue on MacOS by copying images from Safari. This doesn't seem to happen with Firefox, Brave or Chrome.