Pinned conversations do not get removed from UI when deleted

signalapp / Signal-Desktop

A private messenger for Windows, macOS, and Linux.

https://signal.org/download

GNU Affero General Public License v3.0

14.56k stars 2.65k forks source link

Pinned conversations do not get removed from UI when deleted #5953

Open Meteor0id opened 2 years ago

Meteor0id commented 2 years ago

[x] I have searched open and closed issues for duplicates
[x] I am using Signal-Desktop as provided by the Signal team, not a 3rd-party package.

Bug Description

Pinned conversations do not get removed from UI when deleted

Platform Info

Signal Version: 5.45.0

Operating System: Windows 10

Linked Device Version:

Link to Debug Log

scottnonnenberg-signal commented 2 years ago

Just to be clear, you would expect them to be automatically un-pinned when you delete?

TommyDew42 commented 2 years ago

Hi! Love to work on this if what we want is auto un-pinning upon deletion!

Meteor0id commented 2 years ago

You're asking if I expect it to unpin. I'm not sure if it should be unpinned since that only matters if I receive a new message in that chat. The point I was trying to make is that when I delete a chat I expect it to disappear entirely, and pinned chats are not disappearing like any other chat would. It would probably also make sense to not leave it pinned so that if a new message comes in the chat doesn't reappear in the pinned section.

TommyDew42 commented 2 years ago

I checked the signal iOS version. It would be unpinned if I delete an pinned conversation. It also makes sense to unpin the conversation after it is deleted.