signalapp / Signal-Desktop

A private messenger for Windows, macOS, and Linux.
https://signal.org/download
GNU Affero General Public License v3.0
14.6k stars 2.66k forks source link

Crashpad cannot be disabled #5963

Open miaoski opened 2 years ago

miaoski commented 2 years ago

Bug Description

Crashpad cannot be disabled by --disable-crashpad in Linux version of the official app.

Steps to Reproduce

  1. Install signal-desktop per the instruction of the official website.
  2. /opt/Signal/signal-desktop --disable-crashpad in a terminal.
  3. ps ax

Actual Result:

   8626 pts/1    SLl+   0:01      |   \_ /opt/Signal/signal-desktop --disable-crashpad --enable-crashpad
   8629 pts/1    S+     0:00      |       \_ /opt/Signal/signal-desktop --type=zygote --no-zygote-sandbox --enable-crashpad --enable-crashpad
   8668 pts/1    Sl+    0:00      |       |   \_ /opt/Signal/signal-desktop --type=gpu-process --enable-crashpad --enable-crash-reporter=718de9af-fb70-4e59-b28a-7fd9889a0d68,no_channel --user-data-dir=/h
   8630 pts/1    S+     0:00      |       \_ /opt/Signal/signal-desktop --type=zygote --enable-crashpad --enable-crashpad
   8632 pts/1    S+     0:00      |       |   \_ /opt/Signal/signal-desktop --type=zygote --enable-crashpad --enable-crashpad

Expected Result:

User should be able to disable crashpad and choose not to send a crash report with UUID.

Screenshots

Not necessary to include a screenshot.

Platform Info

Signal Version: 5.45.0

Operating System: Ubuntu 22.04 LTS

Linked Device Version: 5.40.4

Link to Debug Log

Not necessary to include a debug log.

indutny-signal commented 2 years ago

Thanks for the report. The crashpad isn't enabled on production versions (only in Beta and development), and in any case it is configured to not send the crashreports to any server. If you experience a crash in dev/beta and restart the app - you will be asked if you'd like to upload the crash report or just delete it.

indutny-signal commented 2 years ago

Meanwhile, we will see if we can make --disable-crashpad work again. Thanks for reporting it.

womanlike commented 2 years ago

The crashpad isn't enabled on production versions (only in Beta and development)

@indutny-signal this is not true in my case either. I run the production version and every Signal process runs with --enable-crashpad. I understand it is not configured to connect to a server, but it's better to nip potential leaks in the bud.