signalapp / Signal-Desktop

A private messenger for Windows, macOS, and Linux.
https://signal.org/download
GNU Affero General Public License v3.0
14.32k stars 2.59k forks source link

Signal desktop fails to send files with unicode characters in their names when using another language #5977

Open sgued opened 2 years ago

sgued commented 2 years ago

Hi!

I have a bug I regularly stumble upon. When I'm using signal in french (Launching it with LANG=fr signal-desktop) and I try to send a file with someone and the name of the file contains non ascii characters, the app crashes (if becomes totally blue and unresponsive, no way to obtain a debug log). This happens regardless of the file type (image, sound, PDF, txt).

When launching it again after killing it and going back to the conversation where this happens, the added file is here but bugged. It appears to load indefinitely. The cross doesn't work, and the only way to remove it is to send a message, which will make it disappear.

image

Here are some errors found in the debug log that may be related to this:

ERROR 2022-06-17T19:57:55.542Z Was unable to generate thumbnail for fileType  {"isTrusted":true}
ERROR 2022-06-17T19:57:55.545Z handleAttachmentsProcessing: failed to process attachment: [object Undefined]

This happens only when LANG=fr is set (the system locale is english).

This happens on both Arch Linux with the signal-desktop package and on Fedora Silverblue 36 with the Signal Desktop flatpak from Flathub.

scottnonnenberg-signal commented 2 years ago

@sgued Would you be willing to reach out directly to provide some of the files (or at least the filenames) in question?

sgued commented 2 years ago

I can reproduce the bug with an empty text file named tèst. French accents (é, è, à) always seem to trigger the bug, with both empty files or real world pdfs/images. I haven't tried with many other unicode characters.

mhoeppner-le commented 1 year ago

Hi, same here with German language and sending any kind of file. Currently installed 6.20.2 from flatpak - and same after update to 6.21.0. Click to add file does not show any file in any folder. Copy a picture and past does not work anymore (was working in a previous version). Any hints?

EDIT: Test with some downgrades done. Problem starts with 6.16.0 // here 6.14.0 is working as expected.

`

  Commit: 7a69cbffa53f8d4962a0a15cfd4c941537c9d2aab7e5175757848f3985adf35c
Subject: Update signal-desktop.deb to 6.16.0 (8c5276b3)
   Date: 2023-04-26 03:05:43 +0000

 Commit: 0a4d650514861c74f5a3a559c9116104922b9aeb4cdcaedc1b364d97b158031a
Subject: Remove unnecessary permissions (#438) (3f78ec79)
   Date: 2023-04-25 08:09:46 +0000

 Commit: 92c53789a85b84f79248e03ddc5fb6c664f17ef988e98fc196d157d5d77a73bf
Subject: Update org.signal.Signal.metainfo.xml (74c6adfa)
   Date: 2023-04-20 10:47:54 +0000

 Commit: ed66a4ac45e2a64c3cf983b9bf5a9cc38091d4b96a1d885c8bf4c1bb54a7ee3b
Subject: Update signal-desktop.deb to 6.14.0 (a91ecbe0)
   Date: 2023-04-12 22:02:26 +0000 

`

scottnonnenberg-signal commented 1 year ago

@mhoeppner-le We need a lot more information from you to try to track this down. First, a debug log would help us determine if there's an error when we try to open a file dialog. Window manager and distro would be good too. But I will warn you that this is something we don't have a lot of control over, this will be a bug we open with Electron.

mhoeppner-le commented 1 year ago

Screen-2023-06-16_16-44-48 Hi, thanks for feedback. I'm not the console nerd. How can I get the required debug log? I use Mageia Linux version 8, KDE-Plasma-version 5.20.4.

EDIT: OK, updated to 6.21.0. Tried the open file dialog - no files shown, than image copy / past - but it did not send the picture.

Debug log transferd to: https://debuglogs.org/desktop/6.21.0/01e4dc95a40cfb92919edcff696dbfec7ec6c7bcc33c006a91f36f4755912c9c.gz

josh-signal commented 1 year ago

Related: https://github.com/electron/electron/issues/34812

mhoeppner-le commented 1 year ago

...6.14.0 I was using until now, shows a message: You have to update, this version is not supported... Update to 6.24.0 and still the same issue with pictures and files :-(