search

signalapp / Signal-Desktop

A private messenger for Windows, macOS, and Linux.
https://signal.org/download
GNU Affero General Public License v3.0
14.66k stars 2.67k forks source link

Signal window looks exactly the same whenever it's active or not #6032

Open haihefa opened 2 years ago

haihefa commented 2 years ago

Bug Description

Since 5.47 update, the title bar and the window borders have been "updated" to match a dark theme. This sounds great! but... there's a catch. Since Signal is now using the same non-native windows borders (as WhatsApp, Telegram do as well) there's just no way to tell if the Signal window is active or not - shadow is ALWAYS the same. I believe, and as a matter of fact, I know, this should be standard desktop functionality, being able to easily tell if a window is active or not.

Steps to Reproduce

  1. Open Signal
  2. Click outside the window
  3. No shadow change at all.

Actual Result:

It's impossible to tell if Signal window is active or not. It looks exactly the same whenever active or not.

Expected Result:

As 5.46 and previous versions did - Signal uses native Windows 10/10 window borders and therefore it was very clear and very easy to tell if Signal window was active or not.

Screenshots

ExactSameWindow

Platform Info

Signal Version:

This issue has been present since 5.47

Operating System:

Windows 11 22621

Linked Device Version:

5.42.8

Link to Debug Log

https://debuglogs.org/desktop/5.50.1/403674d97624bc6d2fa8561fee78ac31019f7aecea928da0f537f23f143d20a5.gz

norstbox commented 2 years ago

Duplicate #5988 and #5985

From my point of view, this is an obvious accessibility issue. I can't make it out, why abovementioned reports treated as feature request / suggestion and not a regression (because Signal versions below 5.47 are not affected by this issue)

scottnonnenberg-signal commented 1 year ago

I think we can keep this open - we might not be going back to the original native window frame, but we would like to show a difference between active/inactive modes.

haihefa commented 1 year ago

Man I wish we could just have an option to choose between original native window frame and the ugly Electron Frame. Reason? There's this utility called MicaForEveryone, and it'd simply make Win32 apps beautiful, including Signal's. Now, it's long gone.