search

signalapp / Signal-Desktop

A private messenger for Windows, macOS, and Linux.
https://signal.org/download
GNU Affero General Public License v3.0
14.69k stars 2.68k forks source link

Linux: App crashes when clicking link in message, if app has been updated #6049

Open bnsmcx opened 2 years ago

bnsmcx commented 2 years ago

Signal-Desktop: 5.51.1 OS: Pop!_OS 22.04 LTS x86_64 Kernel: 5.18.10-76051810-generic

Intermittent bug where clicking a link in a message crashes the app. Unable to reproduce reliably. Reopening the app and clicking the link again typically works.

signal_debuglog.txt

scottnonnenberg-signal commented 2 years ago

This is known to happen if you click a link after your package manager has updated Signal Desktop out from under the running application. Does it always happen for you, or only sometimes?

bnsmcx commented 2 years ago

That appears to be exactly what is happening. I was just able to reproduce it. After upgrading to 5.52.0 via apt I clicked a link and the app crashed.

DooMMasteR commented 2 years ago

This has been happening to me eversince I use Signal (at least 2 years now). It happens very rarely, but every other day the App just quits when clicking a URL. Reopening and then clicking the same URL again works just fine. Currently I am using the packaged version for Ubuntu/Debian on Ubuntu 22.04.1 LTS.

signal-desktop:
  Installed: 5.55.0
  Candidate: 5.55.0
  Version table:
 *** 5.55.0 500
        500 https://updates.signal.org/desktop/apt xenial/main amd64 Packages
        100 /var/lib/dpkg/status
indutny-signal commented 2 years ago

@DooMMasteR do you think the update could have happened in the background right before you clicked the link?

DooMMasteR commented 1 year ago

Not sure, without any indication of an update being ready I cannot be sure.

The behaviour is also still consistent with current versions :cry:

bnsmcx commented 1 year ago

I just tested this again and was able to reproduce the bug by upgrading from 6.12.0 to 6.15.0 via apt and then clicking a link within a message causing the app to crash.

I'd assign a priority to this of just short of "won't fix". I think it would be totally acceptable to just prompt the user that signal needs to restart after an update. This is standard behavior for other mainstream apps such as firefox.

erebion commented 1 year ago

I think it would be totally acceptable to just prompt the user that signal needs to restart after an update. This is standard behavior for other mainstream apps such as firefox.

As long as it does not interrupt the long message I've been writing and then I need to type it all again... ;-)

I've also noticed that issue for some years. It's especially annoying when I type a message, I get a link, click it, Signal crashes and I have to re-type the whole message I was about to send.