signalapp / Signal-Desktop

A private messenger for Windows, macOS, and Linux.
https://signal.org/download
GNU Affero General Public License v3.0
14.69k stars 2.68k forks source link

Dupe of: Signal Desktop freezes PC - no action except a hard reset is possible #2442. Issue still presistant #6102

Closed ramenspazz closed 2 years ago

ramenspazz commented 2 years ago

Duplicate of issue #2442

This issue is still present in fedora 36. I cant get a stack trace or core dump, but if someone could help me with getting one, I can freeze my system and post one.

Reproduce: Do anything and it eventually crashes. No single specific identifiable cause. Right clicking to open a context menu. This also is blank and all drop down menus are also blank. Symptoms: Hard freeze.

alvaro-signal commented 2 years ago

@ramenspazz Can you try starting Signal Desktop from the command line with the --disable-gpu command line argument? Let us know if that prevents it from freezing. If it still freezes, please provide as much detail as you can about your graphics card and driver software and any other information that might be relevant.

ramenspazz commented 2 years ago

No freezes yet with --disable-gpu.

If its helpful, my gpu is as follows: *-display
description: VGA compatible controller product: Renoir vendor: Advanced Micro Devices, Inc. [AMD/ATI] physical id: 0 bus info: pci@0000:04:00.0 version: c3 width: 64 bits clock: 33MHz capabilities: pm pciexpress msi msix vga_controller bus_master cap_list configuration: driver=amdgpu latency=0 resources: irq:47 memory:d0000000-dfffffff memory:e0000000-e01fffff ioport:f000(size=256) memory:fe400000-fe47ffff

The graphics driver is the one included in the linux kernel version 5.19.4-200.fc36.x86_64

githubbapoopa commented 2 years ago

Same crashes here on Win10 with Intel UHD Graphics 620.

First I blamed another software until I found this here.

If Signal can't properly handle gpu accelleration I suggest to disable it by default.

https://github.com/electron/electron/issues/13368

So --disable-gpu is only a workaround but not the solution.

How does this get solved?

scottnonnenberg-signal commented 2 years ago

Good news for linux users: we've disabled hardware acceleration on linux in the most recent beta. Please let us know how it works for you. @githubbapoopa Please consider entering a new bug with your full system (especially graphics hardware/driver) details. I'm going to close this one.

Sylvanas-1977 commented 1 year ago

Good news for linux users: we've disabled hardware acceleration on linux in the most recent beta. Please let us know how it works for you. @githubbapoopa Please consider entering a new bug with your full system (especially graphics hardware/driver) details. I'm going to close this one.

I just froze today and then used argument to disable it and then it was gone so its not disabled by default, i think issue can also happen on windows, altho i did not check in windows. It may only be happening when you share screen with a game, which works fine in app like discord be nice if it could also share audio as well while maintaining mic input

edit: 6900 XT on Arch Linux

scottnonnenberg-signal commented 1 year ago

@Sylvanas-1977 In the latest code, this really does turn off hardware acceleration unless you manually enable it: https://github.com/signalapp/Signal-Desktop/blob/8e4de33d7107235c64aa7b6e8453154dfa2cc259/app/main.ts#L1654-L1656

Does Arch perhaps patch that code out of the app?

Sylvanas-1977 commented 1 year ago

@Sylvanas-1977 In the latest code, this really does turn off hardware acceleration unless you manually enable it:

https://github.com/signalapp/Signal-Desktop/blob/8e4de33d7107235c64aa7b6e8453154dfa2cc259/app/main.ts#L1654-L1656

Does Arch perhaps patch that code out of the app?

I have no idea perhaps it simply does not work unless i add the launch property or coincidence it did't do it yet while having that option enabled this is how i set it up afbeelding

Btw i may be on arch linux but very new to everything i know how to compile some stuff its potentially user error as well but i gladly help figure out what the case is even test stuff if needed.

edit: its signal 6.4.1 vision i am running for info

Sylvanas-1977 commented 1 year ago

Be nice if the options to disable GPU hardware acceleration could be added inside app in the future anyway i am just glad Signal is working better then whatsapp desktop i cant even do video calls on whatsapp desktop anymore on windows :D i can setup my windows in such way that it trigger blackscreens under 2 minutes, i tryit contacting whatsapp devs during beta but they just proceed to give tech support instead :D Anyway thanks for making my life much easier in the last couple of months, i was only having problems with screenshare on Signal, i hope screenshare gets improved in the future, perhaps options to lack resolution of the screenshare in screenshare setting + audio.

nononymousse commented 4 months ago

Be nice if the options to disable GPU hardware acceleration could be added inside app in the future anyway

same here, i’m on a Hackintosh (Ventura 13.6.7) and i disable hardware acceleration on every electron app that i have (othervise crash the system) and signal is the only app that i have that doesn’t have it (and i don’t want to launch it each time from the terminal, a button in the settings will be way easier for everyone)