signalapp / Signal-Desktop

A private messenger for Windows, macOS, and Linux.
https://signal.org/download
GNU Affero General Public License v3.0
14.49k stars 2.63k forks source link

Language switching shortcut triggers menu bar focus #6335

Open alxnik opened 1 year ago

alxnik commented 1 year ago

Bug Description

On a windows machine with multiple languages, the shortcut to change between languages is alt-shift. When writing messages it is common to switch between languages multiple times in a message (switching between English & local language). However when the shortcut is pressed, it is common for signal desktop to lose focus from the message box and focus on the menu bar (file menu). Going back to the message box can sometimes happen with the ESC button, sometimes can happen only by using the mouse.

Although alt button triggering the menu bar is expected behavior, other programs seem to better detect that the expected shortcut is not a single alt. Mozilla firefox (v111.0) is a good example.

Steps to Reproduce

  1. Add multilingual keyboard support on windows
  2. Try to send a message while switching between languages using alt-shift

Actual Result:

Signal desktop focuses on the menu bar (file menu) as if only alt was pressed

Expected Result:

Signal desktop should detect the shortcut and not trigger a change in focus

Screenshots

N/A

Platform Info

Signal Version:

6.10.1 production

Operating System:

Microsoft Windows 11 Pro 10.0.22621 Build 22621

Linked Device Version:

N/A

Link to Debug Log

N/A

sewbacca commented 1 year ago

Same on Windows 10

indutny-signal commented 8 months ago

Sorry for a long delay. Can you still reproduce it? I've quite a few languages enabled in my Windows VM, but can't reproduce it...

alxnik commented 8 months ago

I can still reproduce it on 6.41.0. This issue needs some tries to be reproduced, I think it has to do with the button press timing and possibly happens (cannot confirm for sure) when in the combination of alt-shift, the alt is released a little early.

Although this might sound like user error, signal is the only s/w that this happens.

sewbacca commented 8 months ago

Just happened to me again. I cannot reproduce it well either, but I most often notice it, while in VSCode, then alt tabbing to Signal (v6.42.0). Never noticed such problems with other messengers.