signalapp / Signal-Desktop

A private messenger for Windows, macOS, and Linux.
https://signal.org/download
GNU Affero General Public License v3.0
14.31k stars 2.59k forks source link

Error message "Render process is gone" when killing application with task manager #6411

Closed Nexusmeister closed 1 year ago

Nexusmeister commented 1 year ago

Bug Description

When the signal desktop application gets killed with the task manager, the following error message pops for 1-2 seconds up and instantly disappears (see screenshots). This bug occurs for quite some time.

I cannot say that for sure but I noticed in the past, that if signal is active and I want to shut my pc down, I hear the windows error sound. Maybe this error comes from the signal process while getting shut down.

Steps to Reproduce

  1. Start Signal
  2. Start Task Manager
  3. Find Signal Process
  4. Kill Signal Process

Actual Result:

Error message pops for 1-2 secons up and disappears.

Expected Result:

Signal gets shut down properly and in case of an error the error message stays.

Screenshots

image

Platform Info

Signal Version: 6.16.0

Operating System: Windows 11

Linked Device Version:

Link to Debug Log

https://debuglogs.org/desktop/6.16.0/9db13dd6939faf186be96da1a8604d2e2b330c60700a885f7431033cc386bca9.gz

Main.log: {"level":30,"time":"2023-05-10T20:54:54.310Z","msg":"app.ready: preferred system locales: de-DE"} {"level":30,"time":"2023-05-10T20:54:54.311Z","msg":"locale: Supported locales: af-ZA, ar, az-AZ, bg-BG, bn-BD, bs-BA, ca, cs, da, de, el, en, es, et-EE, eu, fa-IR, fi, fr, ga-IE, gl-ES, gu-IN, he, hi-IN, hr-HR, hu, id, it, ja, ka-GE, kk-KZ, km-KH, kn-IN, ko, ky-KG, lt-LT, lv-LV, mk-MK, ml-IN, mr-IN, ms, my, nb, nl, pa-IN, pl, pt-BR, pt-PT, ro-RO, ru, sk-SK, sl-SI, sq-AL, sr-RS, sr-YR, sv, sw, ta-IN, te-IN, th, tl-PH, tr, ug, uk-UA, ur, vi, yue, zh-CN, zh-HK, zh-TW"} {"level":30,"time":"2023-05-10T20:54:54.311Z","msg":"locale: Preferred locales: de-DE"} {"level":30,"time":"2023-05-10T20:54:54.313Z","msg":"locale: Matched locale: de"} {"level":30,"time":"2023-05-10T20:54:54.353Z","msg":"getSystemTraySetting got fast value MinimizeToSystemTray"} {"level":30,"time":"2023-05-10T20:54:54.353Z","msg":"getSystemTraySetting returning MinimizeToSystemTray"} {"level":30,"time":"2023-05-10T20:54:54.359Z","msg":"app ready"} {"level":30,"time":"2023-05-10T20:54:54.359Z","msg":"starting version 6.16.0"} {"level":30,"time":"2023-05-10T20:54:54.382Z","msg":"media access status granted granted"} {"level":30,"time":"2023-05-10T20:54:54.383Z","msg":"got fast theme-setting value dark"} {"level":30,"time":"2023-05-10T20:54:54.383Z","msg":"MainSQL: updateSchema:\n Current user_version: 81;\n Most recent db schema: 81;\n SQLite version: 3.39.4;\n SQLCipher version: 4.5.3 community;\n (deprecated) schema_version: 358;\n"} {"level":30,"time":"2023-05-10T20:54:54.385Z","msg":"got fast theme-setting value dark"} {"level":30,"time":"2023-05-10T20:54:54.386Z","msg":"got fast theme-setting value dark"} {"level":30,"time":"2023-05-10T20:54:54.387Z","msg":"got fast spellcheck setting true"} {"level":30,"time":"2023-05-10T20:54:54.387Z","msg":"Initializing BrowserWindow config: {\"show\":false,\"width\":1920,\"height\":1019,\"minWidth\":300,\"minHeight\":200,\"autoHideMenuBar\":false,\"titleBarStyle\":\"hidden\",\"titleBarOverlay\":{\"color\":\"#2e2e2e\",\"symbolColor\":\"#e9e9e9\",\"height\":27},\"backgroundColor\":\"#121212\",\"webPreferences\":{\"devTools\":false,\"spellcheck\":true,\"nodeIntegration\":false,\"nodeIntegrationInWorker\":false,\"sandbox\":false,\"contextIsolation\":true,\"preload\":\"[REDACTED]\\preload.bundle.js\",\"backgroundThrottling\":true,\"enablePreferredSizeMode\":true,\"disableBlinkFeatures\":\"Accelerated2dCanvas,AcceleratedSmallCanvases\"},\"icon\":\"[REDACTED]\\build\\icons\\win\\icon.ico\",\"x\":0,\"y\":13}"} {"level":30,"time":"2023-05-10T20:54:54.430Z","msg":"spellcheck: user locales: [\"de-DE\"]"} {"level":30,"time":"2023-05-10T20:54:54.430Z","msg":"spellcheck: available spellchecker languages: [\"af\",\"bg\",\"ca\",\"cs\",\"cy\",\"da\",\"de\",\"de-DE\",\"el\",\"en\",\"en-AU\",\"en-CA\",\"en-GB\",\"en-GB-oxendict\",\"en-US\",\"es\",\"es-419\",\"es-AR\",\"es-ES\",\"es-MX\",\"es-US\",\"et\",\"fa\",\"fo\",\"fr\",\"fr-FR\",\"he\",\"hi\",\"hr\",\"hu\",\"hy\",\"id\",\"it\",\"it-IT\",\"ko\",\"lt\",\"lv\",\"nb\",\"nl\",\"pl\",\"pt\",\"pt-BR\",\"pt-PT\",\"ro\",\"ru\",\"sh\",\"sk\",\"sl\",\"sq\",\"sr\",\"sv\",\"ta\",\"tg\",\"tr\",\"uk\",\"vi\"]"} {"level":30,"time":"2023-05-10T20:54:54.430Z","msg":"spellcheck: setting languages to: [\"de-DE\"]"} {"level":30,"time":"2023-05-10T20:54:54.883Z","msg":"got fast theme-setting value dark"} {"level":30,"time":"2023-05-10T20:54:55.576Z","msg":"got fast spellcheck setting true"} {"level":30,"time":"2023-05-10T20:54:55.578Z","msg":"main window is ready-to-show"} {"level":30,"time":"2023-05-10T20:54:55.578Z","msg":"showing main window"} {"level":30,"time":"2023-05-10T20:54:55.624Z","msg":"System tray service: created"} {"level":30,"time":"2023-05-10T20:54:55.624Z","msg":"System tray service: updating main window. Previously, there was not a window, and now there is"} {"level":30,"time":"2023-05-10T20:54:55.624Z","msg":"System tray service: rendering no tray"} {"level":30,"time":"2023-05-10T20:54:55.624Z","msg":"System tray service: enabling"} {"level":30,"time":"2023-05-10T20:54:55.624Z","msg":"System tray service: rendering the tray"} {"level":30,"time":"2023-05-10T20:54:55.624Z","msg":"System tray service: creating the tray"} {"level":30,"time":"2023-05-10T20:54:55.643Z","msg":"Begin ensuring permissions"} {"level":30,"time":"2023-05-10T20:54:55.884Z","msg":"Ensuring file permissions for 4 files"} {"level":30,"time":"2023-05-10T20:54:55.885Z","msg":"Finish ensuring permissions in 241ms"} {"level":30,"time":"2023-05-10T20:54:56.123Z","msg":"Updating BrowserWindow config: %s {\"maximized\":false,\"autoHideMenuBar\":false,\"fullscreen\":false,\"width\":1920,\"height\":1019,\"x\":0,\"y\":13}"} {"level":30,"time":"2023-05-10T20:54:56.124Z","msg":"config/set: Saving ephemeral config to disk"} {"level":30,"time":"2023-05-10T20:54:56.125Z","msg":"config/set: Saved ephemeral config to disk"} {"level":30,"time":"2023-05-10T20:54:56.341Z","msg":"sending database-ready"} {"level":30,"time":"2023-05-10T20:54:56.847Z","msg":"Prevent display sleep service: allowing display sleep"} {"level":30,"time":"2023-05-10T20:54:56.847Z","msg":"Background throttling enabled because no call is active"} {"level":30,"time":"2023-05-10T20:54:57.260Z","msg":"updater/start: starting checks..."} {"level":30,"time":"2023-05-10T20:54:57.264Z","msg":"checkForUpdatesMaybeInstall: checking for update..."} {"level":30,"time":"2023-05-10T20:54:57.398Z","msg":"checkForUpdates: found newer version 6.17.0 forceUpdate=false"} {"level":30,"time":"2023-05-10T20:54:57.403Z","msg":"checkForUpdates: Found local installer [REDACTED]\update-cache\signal-desktop-win-6.17.0.exe"} {"level":30,"time":"2023-05-10T20:54:57.605Z","msg":"checkForUpdates: differential download size 0"} {"level":30,"time":"2023-05-10T20:54:57.811Z","msg":"App loaded - time: 3458"} {"level":30,"time":"2023-05-10T20:54:57.811Z","msg":"SQL init - time: 32"} {"level":30,"time":"2023-05-10T20:54:57.811Z","msg":"Preload - time: 624"} {"level":30,"time":"2023-05-10T20:54:57.811Z","msg":"WebSocket connect - time: 1614"} {"level":30,"time":"2023-05-10T20:54:57.811Z","msg":"Processed count: 0"} {"level":30,"time":"2023-05-10T20:54:57.811Z","msg":"Messages per second: 0"} {"level":30,"time":"2023-05-10T20:54:57.944Z","msg":"Updating BrowserWindow config: %s {\"maximized\":true,\"autoHideMenuBar\":false,\"fullscreen\":false,\"width\":1936,\"height\":1048,\"x\":-1928,\"y\":-8}"} {"level":30,"time":"2023-05-10T20:54:57.944Z","msg":"config/set: Saving ephemeral config to disk"} {"level":30,"time":"2023-05-10T20:54:57.945Z","msg":"config/set: Saved ephemeral config to disk"} {"level":30,"time":"2023-05-10T20:54:57.948Z","msg":"downloadUpdate: Downloading signature https://updates2.signal.org/desktop/signal-desktop-win-6.17.0.exe.sig"} {"level":30,"time":"2023-05-10T20:54:58.041Z","msg":"downloadUpdate: Saving blockmap https://updates2.signal.org/desktop/signal-desktop-win-6.17.0.exe.blockmap"} {"level":30,"time":"2023-05-10T20:54:58.733Z","msg":"downloadUpdate: Not downloading update https://updates2.signal.org/desktop/signal-desktop-win-6.17.0.exe, local file has the same hash"} {"level":30,"time":"2023-05-10T20:54:58.734Z","msg":"downloadUpdate: Downloaded update, moving into cache dir"} {"level":30,"time":"2023-05-10T20:54:59.159Z","msg":"downloadAndInstall: showing update dialog..."} {"level":30,"time":"2023-05-10T20:55:50.024Z","msg":"got fast theme-setting value dark"} {"level":30,"time":"2023-05-10T20:55:50.024Z","msg":"got fast theme-setting value dark"} {"level":30,"time":"2023-05-10T20:55:50.307Z","msg":"got fast theme-setting value dark"} {"level":30,"time":"2023-05-10T20:56:53.627Z","msg":"close event {\"readyForShutdown\":false,\"shouldQuit\":false}"} {"level":30,"time":"2023-05-10T20:56:53.633Z","msg":"System tray service: rendering the tray"} {"level":30,"time":"2023-05-10T20:56:53.647Z","msg":"close: not showing tray notice"} {"level":50,"time":"2023-05-10T20:56:53.653Z","msg":"Render process is gone: Error: Reason: killed, Exit Code: 1\n at App. ([REDACTED]\app\global_errors.js:88:7)\n at App.emit (node:events:525:35)\n at EventEmitter. (node:electron/js2c/browser_init:2:82409)\n at EventEmitter.emit (node:events:513:28)"}

indutny-signal commented 1 year ago

Hello and thank you for the report. I'm afraid that when the renderer process is killed it is indeed gone and this error is accurate. Is there any reason why you prefer to kill Signal Desktop this way? You are likely aware of it, but killing applications like this might potentially lead to data corruption.

Thanks!

Nexusmeister commented 1 year ago

@indutny-signal First of all, if this is intended behaviour, the error message should stay until the user clicks on "Exit". Instead the window disappears in under 2 seconds (maybe shorter). Not so nice for reading an error message. Secondly, I have the suspicion that while shutting down the computer signal gets killed by windows and throws an error message (cant verify that, just a thought). Maybe this is a coincidence but sometimes my computer gets stuck in the shutdown process and maybe it is related to this weird shutdown behaviour of signal. I only got this suspicion because my computer never gets stuck while shutting down if I closed Signal before.

indutny-signal commented 1 year ago

@Nexusmeister I think the issue is that process monitor likely kills not just renderer process, but also the main process as well. This is why you can see the dialog from main process for a short amount of time until even that gets killed.

Could you try clicking "File > Quit" to see how long it takes for Signal to close on your machine? When you start it afterwards - could you collect a debug log and provide it here, please?

Nexusmeister commented 1 year ago

The shutdown is pretty much instantly.

Did you mean this debuglog: debuglog.txt

While shutting down the other day, Signal threw an cryptic error message (unfortunately didnt capture it). But I was already in the shutdown screen with the windows circle thingy. that was also a little bit weird.

jamiebuilds-signal commented 1 year ago

Okay, the shutdown time doesn't seem particularly concerning

There's sadly not a ton we can do about the way that the system shuts down the processes when using the task manager. Without a "normal" (graceful) shutdown, we can ensure that we're done processing all of the messages in our queues and this can lead to messages getting into bad states. It basically needs to be treated as a crash.

I'm going to close this as it's not actionable at the moment

lookfirst commented 8 months ago

2023-11-20 at 06 50 18 png I'm seeing basically the same error on a Mac. I'm not closing or killing anything.

ayumi-signal commented 8 months ago

@lookfirst Hi, sorry you're experiencing this. Your message says you're "not closing or killing anything" so it sounds like a unrelated issue. To help us track it, can you please file a new issue and include info such as reproduction steps and debug logs? Thanks!

lookfirst commented 8 months ago

@ayumi-signal thanks. https://github.com/signalapp/Signal-Desktop/issues/6681