signalapp / Signal-Desktop

A private messenger for Windows, macOS, and Linux.
https://signal.org/download
GNU Affero General Public License v3.0
14.49k stars 2.63k forks source link

.style_ResizeHandle__2Iivi { -webkit-app-region: no-drag; } breaks dragging behavior on Windows #6458

Open Meteor0id opened 1 year ago

Meteor0id commented 1 year ago

Bug Description

I don't know why this ResizeHandle exists in the first place, but on Windows the two Resize handles are making is much harder to drag and resize Signal Desktop.

context: Normally on Windows you can grab a window anyone on the title bar and start dragging. One common action is to drag the window to the top of the screen and it will turn into a full screen window. The inverse is also common, grab a window by the title bar and drag it down to pop it out of full screen back into windowed mode.

Actual Result:

If a Windows user has Signal desktop in full screen and moves their mouse cursor all the way up, and click hold to start dragging, he will find out he can't drag Signal.

Expected Result:

If a Windows user has Signal desktop in full screen and moves their mouse cursor all the way up, and click hold to start dragging, he should be able to drag Signal anywhere he likes.

Platform Info

Signal Version:

Signal Desktop 6.20.0-beta.2

Operating System: Windows 10

trevor-signal commented 1 year ago

@Meteor0id do you mind sharing a screenshot with annotations indicating where you expect to be able to drag but currently cannot? Thanks!

Meteor0id commented 1 year ago

signal drag annotaion 1 signal drag annotaion 2

Meteor0id commented 1 year ago

@trevor-signal do you need more or different information?

trevor-signal commented 1 year ago

@Meteor0id thanks, this is really helpful. This is likely a bug in a third-party package we use -- we'll investigate and hope to patch. We'll update this thread when we have more information!

Meteor0id commented 1 year ago

@trevor-signal which package is that? Electron does not seem to add these handles so I assume it's some other package.

scottnonnenberg-signal commented 1 year ago

The dependency is frameless-titlebar.

Meteor0id commented 1 year ago

Looks like that project hasn't received attention in years. I propose just overwriting the .style_ResizeHandle__2Iivi style for now. Doesn't look like it's important for anything while it has been breaking default Windows behavior some of us use every day.