Menu bar doesn't respect dark theme on Linux (Wayland)

fincentxyz commented 1 year ago

[x] I have searched open and closed issues for duplicates

It's similar to issue #2592, but not quite. This issue only applies to the menu bar and is on Linux.
[x] I am using Signal-Desktop as provided by the Signal team, not a 3rd-party package.

Bug Description

The menu bar stays light when the dark theme is active.

Steps to Reproduce

Open Signal Desktop
Do not hide the menu bar
Turn on dark mode

Actual Result: The menu bar stays light when dark mode is enabled.

Expected Result: The menu bar becomes dark, like it should when dark mode is enabled.

Screenshots

Platform Info

Signal Version: 6.25.0 production

Operating System: Fedora Linux 38 (Workstation Edition) 64-bit GNOME Version 44.2 Wayland windowing system Linux Kernel 6.3.12

Linked Device Version: 6.25.5

FrodoBaggins74524 commented 1 year ago

I want to work on this issue!

scottnonnenberg-signal commented 1 year ago

@FrodoBaggins74524 If you take a look in the code at where Desktop listens for theme changes, it's likely that the fix for this is in Electron, not in our codebase.

signalapp / Signal-Desktop