signalapp / Signal-Desktop

A private messenger for Windows, macOS, and Linux.
https://signal.org/download
GNU Affero General Public License v3.0
14.66k stars 2.67k forks source link

"The group call has ended" timestamp is misleading, no way to get more detailed information #6810

Open dkg opened 8 months ago

dkg commented 8 months ago

Using a supported version?

Overall summary

When a group call ends, Signal Desktop gets a notification that the call has ended.

On a system that is intermittently online, it may receive that notification with significant delay.

This can lead to an evidently false notification, like a notification in the future. For example, today at 8:30am, i brought Signal Desktop online after having been offline for a day, and got this notification:

signal-desktop-confused-time

Directly underneath the cutoff bar that says "Today", it says "The group call has ended β€’ 10:03am"

Since 10:03am hasn't happened yet today, this is clearly wrong. A Signal Android instance attached to the same group reports that this call actually started at 10:03am on the previous day. From being on the call, I know that it finished about 11:30am.

I see two concrete problems here:

Steps to reproduce

  1. Be part of a group chat, using Signal Desktop
  2. Take your Signal Desktop instance offline
  3. Ensure that the group chat has a video call
  4. Terminate the call
  5. Wait until the next calendar day
  6. Bring Signal Desktop back online
  7. Look at the timestamp of the "The group call has ended" notification

Expected result

I'd expect a "the group call has ended" notification to show the time that the call ended. I'd also expect that notification to be placed in the correct calendar day in the timeline.

Actual result

The notification appears to show up on the wrong calendar day, and shows the start of the call, not the end of the call.

Screenshots

signal-desktop-confused-time

Signal version

7.0.0

Operating system

debian GNU/Linux (testing+unstable, debian 13 aka trixie), amd64, Linux 6.6.15

Version of Signal on your phone

6.47.5

Link to debug log

No response

dkg commented 8 months ago

One other note: when i right-click on a normal message in a group chat, i have an "πŸ›ˆ Info" option, which gives me substantially more information, including detailed timestamps of when the message was sent and when it was received.

I don't see any way to get that kind of information about these "The group call has ended" notifications. When i right-click on them, i only get a "πŸ—‘ Delete" option, there is no "πŸ›ˆ Info" option.

jamiebuilds-signal commented 8 months ago

It's definitely an issue that it is appearing on the wrong day in the timeline, but it is expected that the call have the timestamp of the time it was started, not ended