signalapp / Signal-Desktop

A private messenger for Windows, macOS, and Linux.
https://signal.org/download
GNU Affero General Public License v3.0
14.16k stars 2.57k forks source link

Remove domain that does not exist from pre-generation list, thus fixing build. #6898

Closed g1a55er closed 3 weeks ago

g1a55er commented 3 weeks ago

First time contributor checklist:

Contributor checklist:

Description

Hi! I hope this isn't noise.

I was trying to build the project to test my other contribution. I could not do so successfully. My build kept failing with this error:

Error: getaddrinfo ENOTFOUND create.signal.art
    at GetAddrInfoReqWrap.onlookupall [as oncomplete] (node:dns:118:26) {
  errno: -3008,
  code: 'ENOTFOUND',
  syscall: 'getaddrinfo',
  hostname: 'create.signal.art'
}

When I check for the existence of this domain via dig create.signal.art A +short, I get that no record exists. I also do not see it checking on an external tool (e.g. mxtoolbox.com), so I don't think it's a problem with my machine configuration.

To resolve this, I just removed the "create.signal.art" domain from the generate-dns-fallback.ts file. I see that @indutny-signal created this just a few weeks ago, so hopefully this is the right thing to do.

Test Strategy

All tests passed when I ran yarn ready. I also was able to launch the app and send a message to myself using yarn start.

jamiebuilds-signal commented 3 weeks ago

Oh sorry about this, it's been fixed internally and will be released in the next beta