search

signalapp / Signal-Desktop

A private messenger for Windows, macOS, and Linux.
https://signal.org/download
GNU Affero General Public License v3.0
14.16k stars 2.57k forks source link

Unable to save media or files via Desktop on Linux, while Android works fine #6912

Open arcivanov opened 2 weeks ago

arcivanov commented 2 weeks ago

Using a supported version?

Overall summary

Files don't save on Signal on Linux 7.12, 7.11

Steps to reproduce

  1. Receive a file (playable video OR text MIME)
  2. Click on Save
  3. Dialog pops up to save file, click save
  4. Dialog closes, nothing happens.

No file is create locally of any length.

NB!!! The Debug Log doesn't save locally either. So it looks like a global UI problem.

Expected result

File saves, like before

Actual result

No file is saved.

Screenshots

No response

Signal version

7.12.0

Operating system

Fedora 40

Version of Signal on your phone

Android 7.8.1

Link to debug log

https://debuglogs.org/desktop/7.12.0/154122acdbd7e63197c790160a5db61424b156bf6e7457f6bad8255fc3438c1b.gz

HITMAnsOFT commented 2 weeks ago

Same issue on Kubuntu 22.04.4 LTS, Signal 7.12.0, both Snap and official deb packages.

akutuzov commented 1 week ago

Same here, also Kubuntu 22.04.4 and Signal 7.12.0

v8d commented 1 week ago

Same issue on Arch with version 7.12.0. The only way I've found to save images is to open it and drag the actual image to my file manager (which doesn't give any indication of dragging anything, but still works). This doesn't work with videos or other file types, though, because they can't be dragged.

Also when clicking the download button, this gets written to the journal, as well as to stderr if Signal is started from a terminal:

[122855:0615/153714.144870:ERROR:select_file_dialog_linux_portal.cc(760)] Portal returned error: org.freedesktop.DBus.Error.AccessDenied: Portal operation not allowed: Unable to open /proc/122855/root

rafasaurus commented 1 week ago

Same issue on Arch linux wtih version 7.12.0.

trevor-signal commented 1 week ago

Thanks for the reports. 7.11 introduced a new Electron version (v30), which is possibly related. I've created an Electron Fiddle gist here: https://gist.github.com/trevor-signal/95c543c5e7cd398c6957c78b5cc9fe94. I'd love to know if the save dialog opens on:

Thanks for your help!

arcivanov commented 1 week ago

There is no problem with the opening of the save dialog. It's just after the save dialog is closed with "Save", nothing happens.

trevor-signal commented 1 week ago

Others, can you share debug logs? We're having difficulty reproducing.

mrvanes commented 1 week ago

Another debug log: https://debuglogs.org/desktop/7.12.0/3c05aa67fa8f85922db87ba1cf7e02a474325806f232b17c8c3595c2da1cc9fd.gz

Maybe mentioning that I'm running Signal Desktop in a Wayland session helps?

arcivanov commented 1 week ago

Yes, I'm also on Wayland.

rafasaurus commented 1 week ago
  • 29.1.5

I have tested as you say, only in 29.1.5 opens file dialog, with 30 and 31 file dialog does not even open, I'm using xorg on Arch.

HITMAnsOFT commented 1 week ago

I am running on Xorg. Fiddle opens dialog fine on all versions, but as @arcivanov said both in the description and in the comment, nothing is actually saved.

HITMAnsOFT commented 1 week ago

https://debuglogs.org/desktop/7.12.0/25f7eb0913a7754d2d5d5fd6fb110a4ccdd25920a4d26c3a31d223d724507f09.gz

palant commented 5 days ago

For what it’s worth, this is unrelated to flatpak. If I run the signal-desktop binary directly, it runs outside of the flatpak sandbox but is still unable to save files – dialog opens but clicking “Save” doesn’t actually save the file. Signal 7.13.0 on Fedora 40 (KDE, Wayland).

Thanks for the reports. 7.11 introduced a new Electron version (v30), which is possibly related. I've created an Electron Fiddle gist here: https://gist.github.com/trevor-signal/95c543c5e7cd398c6957c78b5cc9fe94. I'd love to know if the save dialog opens on:

* Electron 30.0.9 (current)

* Electron 29.1.5 (used by Signal 7.10)

* Electron 31.0.1

Thanks for your help!

@trevor-signal I’ve slightly modified your fiddle to actually display the file path returned by showSaveDialog(). The affected Electron versions always return an empty path, that’s the issue here. Versions I tested:

In affected versions, the dialog looks considerably different. Given that and the regression range, it’s a safe bet that this regression was caused by electron#42110.

palant commented 4 days ago

While experimenting with this, I found a work-around. Initially, the Save File dialog incorrectly displays “/” above the file list. Click “Home” first, which will make it display “Home” there (listed files don’t change but some icons do). Then you can select directory/file name and saving will work. There seems to be some issue with the directory paths.

would1920 commented 4 days ago

\

While experimenting with this, I found a work-around. Initially, the Save File dialog incorrectly displays “/” above the file list. Click “Home” first, which will make it display “Home” there (listed files don’t change but some icons do). Then you can select directory/file name and saving will work. There seems to be some issue with the directory paths.在对此进行试验时，我找到了一种解决方法。最初，“保存文件”对话框在文件列表上方错误地显示“/”。首先单击“Home”，这将使其显示“Home”（列出的文件不会更改，但某些图标会更改）。然后您可以选择目录/文件名并保存即可。目录路径似乎存在一些问题。

It worked for me!!!

cheazycrust commented 4 days ago

While experimenting with this, I found a work-around. Initially, the Save File dialog incorrectly displays “/” above the file list. Click “Home” first, which will make it display “Home” there (listed files don’t change but some icons do). Then you can select directory/file name and saving will work. There seems to be some issue with the directory paths.

can confirm this worked for me too!!

arcivanov commented 4 days ago

While experimenting with this, I found a work-around. Initially, the Save File dialog incorrectly displays “/” above the file list. Click “Home” first, which will make it display “Home” there (listed files don’t change but some icons do). Then you can select directory/file name and saving will work. There seems to be some issue with the directory paths.

Confirm this works for me too! Great job!

mrvanes commented 4 days ago

Yes, it works. Thx! Tiny correction to the observation: the dialog initially points to ./ (for me). Not /.