signalapp / Signal-Desktop

A private messenger for Windows, macOS, and Linux.
https://signal.org/download
GNU Affero General Public License v3.0
14.16k stars 2.57k forks source link

time for disappearing messages changes on its own after deleting all messages #6921

Open Meteor0id opened 1 week ago

Meteor0id commented 1 week ago

Using a supported version?

Overall summary

see steps to reproduce

Steps to reproduce

  1. have your timer for disappearing messages disabled
  2. create the notes to self chat by sending some messages to self
  3. now go to settings (in my case on android) and set a default disappearing messages timer
  4. Now delete all the messages and tombstones from note to self

Expected result

Nothing happens. The chat remains set to have messages never disappear. Because you have not deleted the whole chat, you only deleted the messages in it.

Actual result

A message pops up "as soon ass you send a message the timer will be set to x" But when you open the chat settings to change that it is already set to off. The warning disagrees with the setting.

Clearly this whole thing is caused by Signal Desktop not differentiating between a fully deleted chat and a chat in which all messages were deleted. If the whole chat is deleted on all devices it would be ok to change the setting to the overall default as soon as it gets recreated, but if the chat already exists even if empty it should not switch the default timer despite the general setting having changed since creation.

Screenshots

No response

Signal version

7.14.0-beta.1

Operating system

Windows 10

Version of Signal on your phone

7.9.6

Link to debug log

No response

ayumi-signal commented 4 days ago

@Meteor0id Thanks for this report, and I can reproduce the issue.

I checked with the team and seems like it's not intended, since we want to apply the default timer only for "new" chats, and as your report has indicated, just deleting all the messages locally leaves the chat in the list so it should be considered an "old" chat in that case. We will look into fixing it.