Seemingly crashed after updated

avi12 commented 1 month ago

Using a supported version?

[X] I have searched searched open and closed issues for duplicates.
[X] I am using Signal-Desktop as provided by the Signal team, not a 3rd-party package.

Overall summary

After Signal restarted after the update, it randomly told me that "the application crashed"

Steps to reproduce

Signal got an update, I clicked to update as usual
After it booted up, it simply told me that the application crashed, yet still displayed the usual UI

Expected result

Shouldn't have crashed, I guess

Actual result

Got a dialog that told me that the application crashed

Screenshots

Signal version

7.15.0

Operating system

Windows 10 22H2

Version of Signal on your phone

No response

Link to debug log

https://debuglogs.org/desktop/7.15.0/6ca7949cb426ccf5d2c5d8ecbbf3a87bbbb0f6794aa9d16e7a1cf0b5ef013c04.gz

scottnonnenberg-signal commented 3 weeks ago

It looks like you're having GPU problems - I see this in the crash callstack:

8: static void content::`anonymous namespace'::IntentionallyCrashBrowserForUnusableGpuProcess()+0x2d (gpu_data_manager_impl_private.cc:448)

If you open Command Prompt, then run Signal Desktop manually like this, what do you see?

cd C:\AppData\Local\Programs\signal-desktop
Signal.exe

And then, if you add the --disable-gpu command-line argument like this, what do you see?

Signal.exe --disable-gpu

avi12 commented 3 weeks ago

In both cases I see

jamiebuilds-signal commented 3 weeks ago

@avi12 So are you not able to get the app to crash again?

avi12 commented 3 weeks ago

That's the thing, it didn't actually crash, it only displayed the crash GUI but didn't crash in practice

jamiebuilds-signal commented 3 weeks ago

There is info on a crash that happened in your debuglog:

"crash_info": {
    "address": "0x00007ff7493d1c1f",
    "adjusted_address": null,
    "assertion": null,
    "crashing_thread": 0,
    "instruction": null,
    "memory_accesses": null,
    "possible_bit_flips": null,
    "type": "EXCEPTION_BREAKPOINT"
  },

It looks like there are some issues in the Electron framework related to this crash happening when closing windows which would've happened during shutdown, it probably looked just like the window closing normally though.

This is what happened immediately before shutdown, it's interesting that it looks like the window was open, but then showWindow() was called in the middle of when it should be closing the window. This is all within milliseconds of one another so that could be an issue

INFO  2024-07-04T05:39:26.153Z Client.shutdown
INFO  2024-07-04T05:39:26.153Z data.shutdown: shutdown requested. 0 jobs outstanding
INFO  2024-07-04T05:39:26.920Z MainSQL: slow query close duration=767ms
INFO  2024-07-04T05:39:26.920Z requestShutdown: Response received
INFO  2024-07-04T05:39:26.935Z before-quit event {"readyForShutdown":true,"shouldQuit":true,"hasEventBeenPrevented":false,"windowCount":1,"mainWindowExists":true,"mainWindowIsFullScreen":false}
INFO  2024-07-04T05:39:26.935Z System tray service: markShouldQuit
INFO  2024-07-04T05:39:26.935Z close event {"readyForShutdown":true,"shouldQuit":true}
INFO  2024-07-04T05:39:26.936Z NotificationService: clearing notification and updating
INFO  2024-07-04T05:39:26.936Z show window
INFO  2024-07-04T05:39:26.936Z NotificationService not updating notifications. Notifications are enabled; app is not focused; there is no notification data
INFO  2024-07-04T05:39:26.944Z main window closed event
INFO  2024-07-04T05:39:26.944Z System tray service: updating main window. Previously, there was a window, and now there is not
INFO  2024-07-04T05:39:26.944Z System tray service: rendering no tray
INFO  2024-07-04T05:39:26.944Z will-quit event {"hasEventBeenPrevented":false,"windowCount":0,"mainWindowExists":false}
INFO  2024-07-04T05:39:26.944Z quit event {"hasEventBeenPrevented":false,"windowCount":0,"mainWindowExists":false}

To be clear you only clicked the update banner, you didn't click on any other window controls while it was shutting down?

avi12 commented 3 weeks ago

To be clear you only clicked the update banner, you didn't click on any other window controls while it was shutting down?

Indeed

signalapp / Signal-Desktop