build: use `resolve4`/`resolve6` in `build:dns-fallback`. - Githubissues

signalapp / Signal-Desktop

A private messenger for Windows, macOS, and Linux.

https://signal.org/download

GNU Affero General Public License v3.0

14.68k stars 2.68k forks source link

build: use `resolve4`/`resolve6` in `build:dns-fallback`. #6958

Closed jnsgruk closed 3 months ago

jnsgruk commented 3 months ago

First time contributor checklist:

[x] I have read the README and Contributor Guidelines
[x] I have signed the Contributor Licence Agreement

Contributor checklist:

[x] My contribution is not related to translations.
[x] My commits are in nice logical chunks with good commit messages
[x] My changes are rebased on the latest main branch
[x] A npm run ready run passes successfully (more about tests here)
[x] My changes are ready to be shipped to users

Description

dns.lookup relies on making syscalls to the underlying system using getaddrinfo, which can sometimes fail in proxy situations.

This is an equivalent implementation using the native NodeJS DNS functions.

ayumi-signal commented 3 months ago

Thanks so much for your contribution! It's been merged internally and it will show up with the next beta release in about a week.