signalapp / Signal-Desktop

A private messenger for Windows, macOS, and Linux.
https://signal.org/download
GNU Affero General Public License v3.0
14.55k stars 2.64k forks source link

Adding stickers when editing an image is broken #6983

Open Protonator opened 1 month ago

Protonator commented 1 month ago

Using a supported version?

Overall summary

When editing an image before posting it I can no longer add custom stickers to it. I can click them, but they don't appear in the image. Only two of the "selected stickers" (a digital and an analog clock) still work as expected. I also installed a new sticker pack to check if it's just a problem with existing stickers, but the new ones doesn't work, too. This happens under Manjaro and Windows 11 with different versions of Signal Desktop (7.18.0 and above). Drawing or adding text in the image still work as expected.

Steps to reproduce

1.) Paste an image in a signal chat window. 2.) Edit the image. 3.) Try to add a custom sticker.

Expected result

The sticker gets added to the image and can be moved around.

Actual result

The sticker doesn't get added and is not visible.

Screenshots

No response

Signal version

7.18.0 (Manjaro), 7.20.0 (Windows 11)

Operating system

Manjaro KDE and Windows 11

Version of Signal on your phone

No response

Link to debug log

https://debuglogs.org/desktop/7.18.0/52792e55956be4f08ce93f01326ec8c7fe877fc197cbd02e896ce88dbc33d3e7.gz

https://debuglogs.org/desktop/7.20.0/2cad43296befc7ffce3952266343eb29912e1915a623268d92f6d198dcd91838.gz

hackerbirds commented 2 days ago

I also suffer from that issue

Regression happened at https://github.com/signalapp/Signal-Desktop/commit/28664a606f1fd8e912ceca7907de544592a8f938 (I tested it), that change updated the attachments by encrypting them on disk and I guess the media editor can't decrypt the stickers, so it shows nothing.

If I find a fix I'll make a PR myself, otherwise I hope that the signal devs will stop ignoring that issue lol