search

signalapp / Signal-Desktop

A private messenger for Windows, macOS, and Linux.
https://signal.org/download
GNU Affero General Public License v3.0
14.64k stars 2.67k forks source link

Unhandled Error - AssertionError [ERR_ASSERTION]: The expression evaluated to a falsy value #6985

Closed infosecconsultant closed 2 months ago

infosecconsultant commented 2 months ago

Using a supported version?

Overall summary

When opening signal following a reboot, the following error will occasionally appear:

Unhandled Error

AssertionError [ERR_ASSERTION]: The expression evaluated to a falsy value:

  (0, node_assert_1.default)(entry)

    at DefaultStorage.cleanup ([REDACTED]/node_modules/@indutny/range-finder/dist/src/default-storage.js:121:35)
    at DefaultStorage.put ([REDACTED]/node_modules/@indutny/range-finder/dist/src/default-storage.js:93:14)
    at SkipTransform.<anonymous> ([REDACTED]/node_modules/@indutny/range-finder/dist/src/index.js:94:26)
    at Object.onceWrapper (node:events:633:28)
    at SkipTransform.emit (node:events:519:28)
    at SkipTransform._destroy ([REDACTED]/node_modules/@indutny/range-finder/dist/src/skip-transform.js:29:14)
    at _destroy ([REDACTED]/node_modules/@indutny/range-finder/node_modules/readable-stream/lib/internal/streams/destroy.js:92:10)
    at SkipTransform.destroy ([REDACTED]/node_modules/@indutny/range-finder/node_modules/readable-stream/lib/internal/streams/destroy.js:62:5)
    at Object.cancel ([REDACTED]/ts/util/toWebStream.js:54:16)
    at readableStreamDefaultControllerCancelSteps (node:internal/webstreams/readablestream:2390:39)

Steps to reproduce

I am unable to trigger the issue at will.

Expected result

No error

Actual result

Debug log excerpt:

INFO  2024-08-17T23:05:08.842Z AttachmentDownloadManager/runDownloadAttachmentJob/1723867992475.attachment.[REDACTED]1A=: Starting job
INFO  2024-08-17T23:05:08.842Z GET (REST) https://cdn2.signal.org/attachments/[REDACTED]RVb
INFO  2024-08-17T23:05:08.907Z GET (REST) https://cdn2.signal.org/attachments/[REDACTED]RVb 200 Streaming
INFO  2024-08-17T23:05:08.911Z GET (REST) https://cdn2.signal.org/attachments/[REDACTED]7DY 200 Streaming
INFO  2024-08-17T23:05:09.016Z GET (REST) https://cdn2.signal.org/attachments/[REDACTED]7DY 200 Streaming ended
INFO  2024-08-17T23:05:09.037Z GET (REST) https://cdn2.signal.org/attachments/[REDACTED]RVb 200 Streaming ended
INFO  2024-08-17T23:05:09.287Z AttachmentDownloadManager/startJob(1723867992475.attachment.[REDACTED]Uc=): job completed with status: finished
INFO  2024-08-17T23:05:09.293Z AttachmentDownloadManager/startJob(1723867992475.attachment.[REDACTED]Ow=): starting job
INFO  2024-08-17T23:05:09.295Z AttachmentDownloadManager/runDownloadAttachmentJob/1723867992475.attachment.[REDACTED]Ow=: Starting job
INFO  2024-08-17T23:05:09.296Z GET (REST) https://cdn2.signal.org/attachments/[REDACTED]N9w
INFO  2024-08-17T23:05:09.443Z AttachmentDownloadManager/startJob(1723867992475.attachment.[REDACTED]1A=): job completed with status: finished
INFO  2024-08-17T23:05:09.449Z AttachmentDownloadManager/startJob(1723867992475.attachment.[REDACTED]Ug=): starting job
INFO  2024-08-17T23:05:09.452Z AttachmentDownloadManager/runDownloadAttachmentJob/1723867992475.attachment.[REDACTED]Ug=: Starting job
INFO  2024-08-17T23:05:09.452Z GET (REST) https://cdn2.signal.org/attachments/[REDACTED]MRi
INFO  2024-08-17T23:05:09.519Z GET (REST) https://cdn2.signal.org/attachments/[REDACTED]MRi 200 Streaming
INFO  2024-08-17T23:05:09.531Z AttachmentDownloadManager/startJob(1723867992475.attachment.[REDACTED]Dc=): job completed with status: finished
INFO  2024-08-17T23:05:09.533Z AttachmentDownloadManager/startJob(1723867992475.attachment.[REDACTED]M4=): starting job
INFO  2024-08-17T23:05:09.535Z AttachmentDownloadManager/runDownloadAttachmentJob/1723867992475.attachment.[REDACTED]M4=: Starting job
INFO  2024-08-17T23:05:09.535Z GET (REST) https://cdn2.signal.org/attachments/[REDACTED]xjz
INFO  2024-08-17T23:05:09.609Z GET (REST) https://cdn2.signal.org/attachments/[REDACTED]xjz 200 Streaming
INFO  2024-08-17T23:05:09.612Z GET (REST) https://cdn2.signal.org/attachments/[REDACTED]MRi 200 Streaming ended
INFO  2024-08-17T23:05:09.712Z GET (REST) https://cdn2.signal.org/attachments/[REDACTED]xjz 200 Streaming ended
INFO  2024-08-17T23:05:09.838Z GET (REST) https://cdn2.signal.org/attachments/[REDACTED]N9w 200 Streaming
INFO  2024-08-17T23:05:09.982Z AttachmentDownloadManager/startJob(1723867992475.attachment.[REDACTED]Ug=): job completed with status: finished
INFO  2024-08-17T23:05:09.985Z AttachmentDownloadManager/startJob(1723867992475.attachment.[REDACTED]qA=): starting job
INFO  2024-08-17T23:05:09.986Z AttachmentDownloadManager/runDownloadAttachmentJob/1723867992475.attachment.[REDACTED]qA=: Starting job
INFO  2024-08-17T23:05:09.987Z GET (REST) https://cdn2.signal.org/attachments/[REDACTED]AIl
INFO  2024-08-17T23:05:10.039Z GET (REST) https://cdn2.signal.org/attachments/[REDACTED]AIl 200 Streaming
INFO  2024-08-17T23:05:10.161Z GET (REST) https://cdn2.signal.org/attachments/[REDACTED]N9w 200 Streaming ended
INFO  2024-08-17T23:05:10.271Z GET (REST) https://cdn2.signal.org/attachments/[REDACTED]AIl 200 Streaming ended
INFO  2024-08-17T23:05:10.274Z AttachmentDownloadManager/startJob(1723867992475.attachment.[REDACTED]M4=): job completed with status: finished
INFO  2024-08-17T23:05:10.279Z AttachmentDownloadManager/startJob(1723867992475.attachment.[REDACTED]zA=): starting job
INFO  2024-08-17T23:05:10.281Z AttachmentDownloadManager/runDownloadAttachmentJob/1723867992475.attachment.[REDACTED]zA=: Starting job
INFO  2024-08-17T23:05:10.281Z GET (REST) https://cdn2.signal.org/attachments/[REDACTED]zEk
INFO  2024-08-17T23:05:10.346Z GET (REST) https://cdn2.signal.org/attachments/[REDACTED]zEk 200 Streaming
INFO  2024-08-17T23:05:10.414Z GET (REST) https://cdn2.signal.org/attachments/[REDACTED]zEk 200 Streaming ended
ERROR 2024-08-17T23:05:10.421Z Unhandled Error: AssertionError [ERR_ASSERTION]: The expression evaluated to a falsy value:

  (0, node_assert_1.default)(entry)

    at DefaultStorage.cleanup ([REDACTED]/node_modules/@indutny/range-finder/dist/src/default-storage.js:121:35)
    at DefaultStorage.put ([REDACTED]/node_modules/@indutny/range-finder/dist/src/default-storage.js:93:14)
    at SkipTransform.<anonymous> ([REDACTED]/node_modules/@indutny/range-finder/dist/src/index.js:94:26)
    at Object.onceWrapper (node:events:633:28)
    at SkipTransform.emit (node:events:519:28)
    at SkipTransform._destroy ([REDACTED]/node_modules/@indutny/range-finder/dist/src/skip-transform.js:29:14)
    at _destroy ([REDACTED]/node_modules/@indutny/range-finder/node_modules/readable-stream/lib/internal/streams/destroy.js:92:10)
    at SkipTransform.destroy ([REDACTED]/node_modules/@indutny/range-finder/node_modules/readable-stream/lib/internal/streams/destroy.js:62:5)
    at Object.cancel ([REDACTED]/ts/util/toWebStream.js:54:16)
    at readableStreamDefaultControllerCancelSteps (node:internal/webstreams/readablestream:2390:39)
INFO  2024-08-17T23:05:10.591Z WebSocketResources.KeepAlive(unauthenticated).send: Sending a keepalive message
INFO  2024-08-17T23:05:10.900Z RoutineProfileRefresher.start/2: waiting for 3535800ms
INFO  2024-08-17T23:05:11.011Z WebSocketResources.KeepAlive(authenticated).send: Sending a keepalive message
INFO  2024-08-17T23:05:11.275Z checkExpiringMessages: checking for expiring messages
INFO  2024-08-17T23:05:18.024Z main window closed event
INFO  2024-08-17T23:05:18.024Z System tray service: updating main window. Previously, there was a window, and now there is not
INFO  2024-08-17T23:05:18.024Z System tray service: rendering no tray
INFO  2024-08-17T23:05:18.025Z quit event {"hasEventBeenPrevented":false,"windowCount":0,"mainWindowExists":false}

Screenshots

No response

Signal version

7.20.0 production (Intel)

Operating system

Macos 13.6.7

Version of Signal on your phone

No response

Link to debug log

No response

nisori commented 2 months ago

+1

I am experiencing this issue as well. It started with the bootup of my system today, and happened again twice when trying to start the software. Once it stopped crashing (and I've read this bug report), I've tried to reproduce with a reboot of my system, which did not lead to another crash.

Mushoz commented 2 months ago

Happening here as well on Archlinux, so it does not look like it's MacOS specific.

AsebWebDev commented 2 months ago

Same here on MacOS and on Windows 11. Seems to happen randomly when starting signal. Giving it one or more tries usually works. Comes back nevertheless.

UKsingh13 commented 2 months ago

Same thing happened to me last week but then it started working ok. Now happening again today.

Closing and relaunching Signal Desktop seems to have fixed the issue.

I think this error occurs when Signal Desktop fails to connect to Signal servers, rather than an error with the software itself. Until it can establish a secure connection it will probably throw up this error.

indutny-signal commented 2 months ago

Sorry about this. We'll fix it in the next release!

indutny-signal commented 2 months ago

Could you give a try to 7.20.1 to see if it is any better, please? Thank you ❤️

infosecconsultant commented 2 months ago

Haven't seen any crashing occur. But did notice a new bug, I sent 32 photos, followed by an additional 8 to a contact. In the desktop client, I can only see one photo displayed and not the usual 5 tiles +27 icons for the 32. But for the 8, I see the 5 icons +3 immediately after. If I click on the one image displayed for the 32, i can scroll through the other 31 images without problem.

Behaves as expected on the mobile client.

Issue persists after a restart of the desktop client. Does not appear to affect previously sent image batches.

image

UKsingh13 commented 2 months ago

Could you give a try to 7.20.1 to see if it is any better, please? Thank you ❤️

Thanks, update is working fine.