search

signalapp / Signal-Desktop

A private messenger for Windows, macOS, and Linux.
https://signal.org/download
GNU Affero General Public License v3.0
14.66k stars 2.67k forks source link

Enable building for rpm-based distros #7003

Closed ralvarezt closed 2 months ago

ralvarezt commented 2 months ago

First time contributor checklist:

Contributor checklist:

Description

Successful build and usage with Fedora 40 KDE in x86_64. The build completes and the packages installs successfully with dnf.

brjsp commented 2 months ago

This commit is wrong — you should not specify package names explicitely on RPM systems as they may differ between distros (Fedora vs SUSE vs Mageia etc.) Rpmbuild should detect needed sonames automatically from any oncluded binaries (but i'm not sure if electron-builder is calling it correctly)

ralvarezt commented 2 months ago

Thanks for the pointer Bruno, the main branch already does that for deb package building too, so I tried to do the same. Does removing the requires part would make it pass for you?

El mar, 3 sept 2024 a las 11:03, Bruno Pitrus @.***>) escribió:

This commit is wrong — you should not specify package names explicitely on RPM systems as they may differ between distros (Fedora vs SUSE vs Mageia etc.) Rpmbuild should detect needed sonames automatically from any oncluded binaries (but i'm not sure if electron-builder is calling it correctly)

— Reply to this email directly, view it on GitHub https://github.com/signalapp/Signal-Desktop/pull/7003#issuecomment-2325981113, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADE5ABAUCCGB7OF3UBO6S63ZUV3N3AVCNFSM6AAAAABNP4R4YGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMRVHE4DCMJRGM . You are receiving this because you authored the thread.Message ID: @.***>

ralvarezt commented 2 months ago

Pushed a change to remove depends as @brjsp suggested.

ayumi-signal commented 2 months ago

We are not currently ready to add RPM support, furthermore this PR appears to remove DEB support. Current intention is that a distribution neutral linux package will eventually provide support for Fedora.