Add rpm and appimage builds

ralvarezt commented 2 months ago

First time contributor checklist:

[X ] I have read the README and Contributor Guidelines
[X ] I have signed the Contributor Licence Agreement

Contributor checklist:

[X ] My contribution is not related to translations.
[X ] My commits are in nice logical chunks with good commit messages
[X ] My changes are rebased on the latest main branch
[X ] A npm run ready run passes successfully (more about tests here)
[X ] My changes are ready to be shipped to users

Description

Provide rpm and appimage builds without breaking deb builds. Fixes #1758 and other rpm-related issues.

ayumi-signal commented 2 months ago

Thanks for your contribution. We are not ready to add these platforms yet. Please consult with us before opening pull requests which affect the release flow.

ralvarezt commented 2 months ago

What do you mean you're not ready yet? This change has been tested in a Fedora installation without issues.

ayumi-signal commented 2 months ago

Regarding supported platforms, we validate releases on all supported OS'es (MacOS, Windows, Ubuntu) using automated and manual testing. Furthermore our build pipeline must be updated.

By specifically including Fedora then it is an implicit guarantee that the app is going to work as expected.

We want to make signal as universally available as possible, but we currently don't have developer bandwidth to do these steps, and when we're ready then we will take these steps.

ralvarezt commented 2 months ago

I'm happy to help and improve testing if you can share the test suite for production releases.

El vie, 6 sept 2024 a las 19:31, ayumi-signal @.***>) escribió:

Regarding supported platforms, we validate releases on all supported OS'es (MacOS, Windows, Ubuntu) using automated and manual testing. Furthermore our build pipeline must be updated.

By specifically including Fedora then it is an implicit guarantee that the app is going to work as expected.

We want to make signal as universally available as possible, but we currently don't have developer bandwidth to do these steps, and when we're ready then we will take these steps.

— Reply to this email directly, view it on GitHub https://github.com/signalapp/Signal-Desktop/pull/7007#issuecomment-2334517097, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADE5ABDUG36APMYS2Q7T5ILZVHRFXAVCNFSM6AAAAABNTRBUQ6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMZUGUYTOMBZG4 . You are receiving this because you authored the thread.Message ID: @.***>

signalapp / Signal-Desktop