signalapp / Signal-Desktop

A private messenger for Windows, macOS, and Linux.
https://signal.org/download
GNU Affero General Public License v3.0
14.68k stars 2.68k forks source link

updateToSchemaVersion1100 test is flaky #7022

Open brjsp opened 2 months ago

brjsp commented 2 months ago

Using a supported version?

Optimize markAllCallHistoryReadInConversation occasionally fails with this error message:

  1) SQL/updateToSchemaVersion1100
       Optimize markAllCallHistoryReadInConversation
         is fast:

      AssertionError: expected 59.411166000001685 to be below 50
      + expected - actual

      -59.411166000001685
      +50

      at Context.<anonymous> (ts/test-node/sql/migration_1100_test.js:1:2204)
      at process.processImmediate (node:internal/timers:483:21)

Signal version

7.25.0 and a few previous ones

Operating system

Linux (various openSUSE/Fedora)

mosbat commented 2 months ago

I had this error message but after installing the nodeJS version stated in the documentation, it was gone. You can find info here: https://github.com/signalapp/Signal-Desktop/blob/main/.nvmrc

Let me know if this fixed the problem.

brjsp commented 2 months ago

@mosbat the advice is nonsense — the tests are run under Electron, not Node, so the Node version is irrelevant.

anyway we'll probably just patch out that test since it seems to measure some timing and our build machines are rather slow.

mosbat commented 2 months ago

@brjsp context matters but you didn't mention anything about Electron