signalapp / Signal-Desktop

A private messenger for Windows, macOS, and Linux.
https://signal.org/download
GNU Affero General Public License v3.0
14.66k stars 2.67k forks source link

The JPEG XL pictures / photos are treated as non photo file types. #7026

Open t0maz opened 1 month ago

t0maz commented 1 month ago

Using a supported version?

Overall summary

The JPEG XL pictures / photos are treated as non photo file types. For example when JPEG (jpg) file is attached the preview is generated while attaching JPEG XL (jxl) file is not generating the preview which is confusing the reciver(s).

This issue is different than https://github.com/signalapp/Signal-Desktop/issues/6312 as the jxl files are opening correctly without problems reported there. Additionally the format is now officially supported on all Apple devices since introduction of macOS 14 and iOS 17. Also there is no such issue with mobile app on iOS (when shared from system context menu) but I can't test it with desktop Signal as it's missing in the macOS share context menu list.

Steps to reproduce

  1. Go to chat
  2. Drag and drop JPEG XL (jxl) file with picture or photo into chat

Expected result

The JPEG XL (jxl) file should be attached as picture/photo file resulting in generating a preview/thumbnail like for JPEG (jpg) files.

Actual result

The JPEG XL files are treated and attached as regular (non-picture/non-photo) files.

Screenshots

Screenshot 2024-09-25 at 21 41 40

Signal version

7.25.0 production (Apple silicon)

Operating system

macOS Sequoia 15.0

Version of Signal on your phone

7.29 (341)

Link to debug log

No response

brjsp commented 1 month ago

There is really no way to display them as-is. JXL support was removed last year in Electron 23.

t0maz commented 1 month ago

Is there a way for signal to convert JXL automatically to supported format ie. to jpg?

Meanwhile I've raised a feature request for Electron -> https://github.com/electron/electron/issues/43993 perhaps they may reconsider it now when JXL gained support in whole Apple world.