signalapp / Signal-Desktop

A private messenger for Windows, macOS, and Linux.
https://signal.org/download
GNU Affero General Public License v3.0
14.69k stars 2.68k forks source link

"Delete message" confirmation dialog is not confirmable per kbd shortcut (Enter) #7027

Closed nerdoc closed 2 months ago

nerdoc commented 2 months ago

Using a supported version?

Overall summary

Dialogs should be closeble per keyboard: Enter for default action, ESC for "cancel" action. In Signal Desktop, when deleting messages, the confirmation dialog does the "cancel" action on pressing Enter.

Steps to reproduce

  1. Go to any chat
  2. Delete a message using mose: right klick -> delete
  3. the confirmation dialog pops up
  4. press Enter
  5. The dialog closes, but the message ist not deleted.

Expected result

Message should be deleted on Enter, and action cancelled only on ESC.

Actual result

Nothing happens, message is not deleted.

Screenshots

No response

Signal version

7.25.0 (Ubuntu via Signal's apt repository)

Operating system

Ubuntu 22.04 LTS

Version of Signal on your phone

n/a

Link to debug log

No response

indutny-signal commented 2 months ago

Hello! Thank you for this report. This is fairly typical UX pattern for destructive actions: Enter key selects non-destructive option, and you have to press "Tab" to select the destructive option.