Context menu for marked emoji incorrect

[UserX404]

Using a supported version?

• [X] I have searched searched open and closed issues for duplicates.
• [X] I am using Signal-Desktop as provided by the Signal team, not a 3rd-party package.

Overall summary

As already reported at the forum there is a difference when marking text with emoji where you place the mouse when opening the context menu.

• You can mark text only - context menu “copy”
• You can mark emoji only - no context menu
• You can mark text AND emoji - context menu depends if you right-click on marked text or on marked emoji

Apart from the wrong/different menu text the emoji gets inserted as emoji and not as text

Steps to reproduce

1. mark portion of text with emoji in it
2. right-click on emoj

Expected result

context menu shows with copy as it opens when clicking on text part

Actual result

context menu displays copy image instead of copy.

Screenshots

Signal version

7.29.0

Operating system

W10 x64

Version of Signal on your phone

7.20.1

Link to debug log

https://debuglogs.org/desktop/7.29.0/7a8a56689a37088c35b0f63a9a617dddbe1ab8866f3f8346c2c5dcee6bafd31c.gz

[khuddite]

I will take a look at this issue, thanks for your details @UserX404

[khuddite]

As a first contributor, I had trouble running the project locally due to the above error.

Here are the steps I took to get to where I was stuck

1. npm install (it seemed successful)
2. npm run generate
3. SIGNAL_ENABLE_HTTP=1 npm start
4. On 3 separate terminals, I ran these commands on each - npm run dev:transpile, npm run dev:sass, npm run dev

5. I created a Signal-development directory to populate some data for testing from the production app following the steps described under The staging environment section in the contribution guide.

   While I understand this may be an issue specific to me, I think there is room for improvement here for a more readable and user-friendly error message.

   @jamiebuilds-signal If you can help me out, that would be highly appreciated. Thanks

[scottnonnenberg-signal]

@khuddite Thanks for jumping in to help! What error are you running into, exactly? It's not immediately obvious to me looking at your screenshot and steps...

[khuddite]

Thanks for your help! @scottnonnenberg-signal I know build issues may be too basic to spend your time on.

The error happens once I verify the registration code, enter my name, and hit the Register button at the bottom. I think an exception occurred, and because I am in development mode, the debugger has stopped, and it displays the call stack on the right side.

Please let me know if you need any more details or information. I will attach a video recording shortly, too.

[khuddite]

https://www.loom.com/share/50adeb2848074e0392d7c79bd5e28b1c

I recorded a Loom video because Github doesn't allow a file of more than 10MB. This time, I was already provisioned to the application somehow, but I hit the same issue when I tried to update the profile. The profile was missing a name because I couldn't set it last time due to the problem I reported. Also, I could not send the messages to myself because the loading spinner was spinning forever.

An exception occurs, and its message is just profileKey, you can reference the call stack in the recording.

Thanks again for your help.

[scottnonnenberg-signal]

Ah, I see it's the assert that's firing. I'd recommend that you try, in your step #5, to start from zero data, instead of data from your production app. You don't need your production data to work on this task.