signalapp / Signal-Desktop

A private messenger for Windows, macOS, and Linux.
https://signal.org/download
GNU Affero General Public License v3.0
14.64k stars 2.67k forks source link

No message sending arrow in signal desktop 0.23! #906

Closed jeremymasters closed 8 years ago

jeremymasters commented 8 years ago

Bug description

No sending arrow for messages!

Steps to reproduce

Actual result:

Platform info

Operating System: Windows 7 Browser: Chrome Version 53.0.2785.116 m Signal version: 0.23.0

Link to debug log

https://gist.github.com/fadadec22d025ed24799c3ec3072ab9b

jeremymasters commented 8 years ago

I can, however, hit the key to send a message. The arrow disappearing is certainly disconcerting but not fatal.

2-4601 commented 8 years ago

Hmm... has there ever been an arrow there? I couldn't find it, e.g. see this screenshot from v. 0.1.3 https://github.com/WhisperSystems/Signal-Desktop/issues/482#issue-121057157

liliakai commented 8 years ago

"Do not try and send with the arrow, that's impossible. Instead, only try to realize the truth...there is no arrow. Then you will see it is not the arrow that sends, it is only yourself."

See also: Hangouts, Slack, and iMessage for examples of other desktop chat clients that get by just fine with no send button. :wink:

jeremymasters commented 8 years ago

"You're honor, my client is clearly not competent to stand trial. I rest my case" :laughing:

sorry if I over-played it.

scienmind commented 8 years ago

I would argue that having a "Send" button of any kind would be preferable, it's intuitive to have. Sure you can go without it just fine, but is there any actual reason against it?

(also, I bet most of "non-techy" users would prefer it present rather than absent)

Phil-D54 commented 3 years ago

I would like (on my laptop version) to be able to use the return key for newline and have a seprate 'send' button. I'm used to using the return key and so, probably like a lot of other users, keep sending single line messages.

Having a 'send' button would make the network traffic more efficient. the amount of data sent overall will be the same, however there will be less messages with their associated message swithing characters traversing the network.

Also havig longer complete messages will probably allow optimisation of the packet switching by using optimal sized packets rather than lots of single line (even character) messages.

Plus it would reflect how this github comment box works.

Consistency across platforms provides efficiency.