99 issues for 2.0

[corbett]

@corbett and @FredericJacobs

• [ ] #370 Set "Conversation Safe Words" label in active conversation view
• [x] center the update/leave/members vertically on group convo dropdown
• [x] light gray hairline at top of inbox/archive switcher.
• [ ] light gray hairline at the bottom of the contact details dropdown.
• [ ] left transition for settings (some prototyping in reverse_settings_transition where I create a nave stack with the settings artificially at base)
• [x] text and image together (android has capability of sending)
• [x] not use directories backed up in iCloud for attachment storage
• [x] New Message view needs way to be refreshed when placeholder is displayed.

  @abolishme

waiting for tasks

Completed

• [x] App Store-sized Icon + vectorial icon in repo TOP PRIORITY
• [x] tap and hold "my fingerprint" button for five seconds just does "abort secure session" ... not "shred", which was previously the red button on the fingerprint screen. remove red button. (ask moxie for details). if user wants to clear history, they delete the conversation in the inbox/archive view. (REMOVED)
• [x] improve twitter link image
• [x] constraints on the invisible buttons on the fingerprintview controller are off (check by setting the background to something non clear). TOP PRIORITY
• [x] on 6Plus bottom inbox/archive bar not constrained on left MEDIUM PRIORITY
• [x] delete button in inbox slightly poorly constrained on 6Plus (bleeds in) MEDIUM PRIOIRTY
• [x] constraint on table view cell, would be nice to have a longer preview message string (cuts off halfway through due to constraints)
• [x] review status bar changes and make suggestions (colors, size?)
• [x] paperclip for attach should be ows_ blue (need an icon for this then that is that color)
• [x] in the build new conversation table, when you tap the phone icon, it should automatically launch a new call, and add the conversation to the inbox in the background (this should be a button before I hook it up)
• [x] crash on search country code
• [x] in add new message hide phone if user not redphone user. (this should be a button before I hook it up)
• [x] BUG inbox on first launch doesn't update names (unless you select archive/inbox then updates) doing this selection in code doesn't work. mysterious yapdb related bug introduced. (@fredericjacobs will fix)
• [x] contact details dropdown should have translucent "vibrancy".
• [x] calls updates in JSQ styling.
• [x] group updates in JSQ styling.
• [x] crash on search country code
• [x] fix identity key tap to verify
• [x] image full screen view no longer has save button
• [x] searching for contact, create group, search bar doesn't dismiss
• [x] empty message has latest timestamp, can't be deleted
• [x] replace back button or nav bar by signal icon where appropriate (places it says "Signal" now)
• [x] format "my number" in settings
• [x] always show "hint" labels on contact security details screen. remove "hints button".
• [x] hide entire "their fingerprint" subview in contact security details unless the key material is present
• [x] #372 space between keyboard and button confirm
• [x] #372 spinner or some progress indicator (@abolishme) disabling buttons while request outstanding
• [x] #371 delete account button row not resized
• [x] #371 Name, change, and phone number positioned incorrectly
• [x] #368 speaker button assets
• [x] drop down on conversation view
• [x] Add cancel button to registration view
• [x] spinners on verification view
• [x] signal icon on phone number enter is not centered any more (everything else looks great)
• [x] #370 buttons needed
• [x] #446 replace empty group avatar
• [x] #369 buttons needed
• [x] verify code submit verification code missing spinner (other spinners are present)
• [x] empty message inbox/archive state
• [x] add phone icon to ContactTableViewCell for contacts with RedPhone
• [x] #364 this view needs complete stylizing within JSQ
• [x] style conversation view
• [x] redesign plus icon
• [x] design contact security screen
• [x] call status font color ... red has to change
• [x] define colors
• [x] #362 search bar is off
• [x] Set safe word pair text color to ows_blue
• [x] Call status "failed" or "call ended" red needs to change to ows red specified above
• [x] plugin #369 buttons needed
• [x] "send invite to unregistered number" should be ows_blue.
• [x] turn vibrancy off on all blue navigation bars, looks like it is on and changing the way our blue appears.
• [x] remove "info" button on network status
• [x] add status bar back in with different colors
• [x] fill out initializeTextInputBox method with fonts abolishme specified
• [ ] filter redphone only users from the contact list

Colors

• black: #080A00
• blue: #2090EA
• green: #92FF8A
• red: #FF3867
• gold: #FFBB5C

[abolishme]

@corbett : note that the "add contact" button on the left should only appear for conversations with a phone number not already saved on your phone, otherwise show contact-launch@1x with the circle

[corbett]

spacing in the event of no phone in the middle? 61*2+?

On Wed, Jan 21, 2015 at 12:53 PM, Tyler Reinhard notifications@github.com wrote:

[image: contact-details-guide] https://cloud.githubusercontent.com/assets/3347534/5846988/59bd193e-a196-11e4-95aa-c069c14ca4cf.jpg [image: contact-details] https://cloud.githubusercontent.com/assets/3347534/5846987/59b896b6-a196-11e4-8bd5-81e096af39a9.jpg

— Reply to this email directly or view it on GitHub https://github.com/WhisperSystems/Signal-iOS/issues/439#issuecomment-70938783 .

Dr. Corbett Moran Rockets @ http://www.spacex.com Physics @ http://www.ICS.uzh.ch http://www.ICS.uzh.ch Dev @ http://circleof6app.com Dev @ https://whispersystems.org www.christinecorbettmoran.com

[abolishme]

(61 * 2) + 66 = 188, where 66 is the width of the phone button. So the contact cards do not move if there is no phone icon.

[corbett]

I need to know what you want the width of the phone to be. that is the ?

On Wed, Jan 21, 2015 at 2:04 PM, Tyler Reinhard notifications@github.com wrote:

(61 * 2) + 66 = 188, where 66 is the width of the phone button. So the contact cards do not move if there is no phone icon.

— Reply to this email directly or view it on GitHub https://github.com/WhisperSystems/Signal-iOS/issues/439#issuecomment-70947556 .

Dr. Corbett Moran Rockets @ http://www.spacex.com Physics @ http://www.ICS.uzh.ch http://www.ICS.uzh.ch Dev @ http://circleof6app.com Dev @ https://whispersystems.org www.christinecorbettmoran.com

[abolishme]

yes @corbett, the phone is 66pts wide

[corbett]

reload

[corbett]

reload

[abolishme]

make frame 22pt tall and 400 wide, center text vertically and horizontally. constrain the edges of the label to leading and trailing and top of subview

Helvetica Neue Medium, then Helvetica Neue Light. both 8pt, ows_blue. am pm gets CAPS.

[abolishme]

some empty state brainstorms, the one with the line is a vector image called first-empty-state in the assets folder

[abolishme]

16pt helvetica neue bold 16pt helvetica neue regular, gray ish. (you got it)

[abolishme]

instead of the string "Signal" in the inbox/archive navigation bar, we want the signal logo. the file is already in the assets folder, and above is a demonstration of the button inset settings. I don't know how to add a item to the navigation controller, so i temporarily replaced the settings icon in the image above for reference, but note that the icon should be centered and replace the word signal, not on the left.

[corbett]

8 font is really small for the phone calls

[corbett]

height of the signal icon in nav bar should be 30x30

[shibacomputer]

Re:

left transition for settings

Rethink required for the current primary action button "Done" as this is inconsistent with conventional iOS UX.

[shibacomputer]

@corbett @FredericJacobs thoughts on these?

vs

Context Option A

Option B

[shibacomputer]

Re empty dashed avatar spaces

[shibacomputer]

Examples of swipe actions on tableview cells:

Move to Archive:

Back to Inbox:

[shibacomputer]

New onboarding designs, 99% the same as what we have but with header @ 16pt and a subheader at 14pt.

[shibacomputer]

Todos

Inbox / Archive

• [x] fix delete bug (set one color/icon one place, and another another)
• [x] Update tab bar items with revised PDFs
• [x] Blue outline around avatar-less contacts
• [x] Red bar along the bottom of 6 + cells
• [x] Replace swipe left actions with btnDelete--white asset
• [x] Swipe left background colour to extend the length of the cell (eg like swipe right blue length)
• [x] Replace swipe right buttons with cellBtnMoveToArchive--blue and cellBtnMoveToInbox--blue respectively
• [x] Empty State update with asset and new copy
• [x] Default group name should be 'New Group'
• [ ] Slight alignment issue with avatarless contacts
• [x] Inbox count text resize and reposition (15pt Regular):
• [x] Delete cell - cellBtnDelete -- 82x72

Settings

• [ ] Transition
• [x] Done icon replaced with btnSignal
• [x] Swap blue and grey for Registered Number and Change (change doesn't look like a button)
• [x] UI Switch on should be Signal Blue.
• [x] Update green colour (tbc)

New Message

• [x] Phone icon out of alignment on 6+
• [x] Empty State update with asset and new copy
• [ ] Empty State without contact icon (uiEmpty), blue system spinner inside while you're looking for contacts.
• [x] Disable search ui + group button while downloading contacts

Conversation

• [x] Icon size revisions on new message bar
• [ ] Text alignment revision on new message bar.
• [ ] Fade between call and send buttons

New Group

• [x] Create button should be btnCompose--white
• [x] Add people to be a tableview header (ask @helveticade for creatives)

Groups + Messages

• [ ] More padding above and below status messages (8 pt?)
• [x] Status icons inline with status messages (stat * assets)
• [x] Send button = btnSend--blue
• [x] Attachments button = btnAttachments--blue
• [x] Remove more button
• [ ] Attachment button should be 21x25 (will need QA here)

Onboarding

• [ ] Header 18pt Medlum, Subheader 14pt Regular
• [x] New background for all bgOWSOnboarding
• [ ] Better alignment for everything onboarding (let's work directly together on this)

Empty States

• [x] Iconography @ 115x110
• [x] Message copy 15pt bold headline + 14pt regular.

Colour Palette update

Blue: #2090EA Alt Blue: #B6DEF4 Red: #FF3867 Green: #7DD977 Orange: #F5BA62 White: #F2F2F2 Black: #444444

[corbett]

• [x] no warnings on repo

Todos design

App store

• [x] App Store-sized Icon + vectorial icon in repo

  Inbox / Archive

• [ ] Slight alignment issue with avatarless contacts (initials apparently slightly off)
• [x] on 6Plus bottom inbox/archive bar not constrained on left
• [x] constraint on table view cell, would be nice to have a longer preview message string (cuts off halfway through due to constraints)

Call screen

• [ ] #370 Set "Conversation Safe Words" label in active conversation view

Settings

• [ ] Stretch goal: Transition a nav transition back

Conversation

• [ ] Text alignment revision on new message bar.
• [ ] Fade between call and send buttons
• [x] center the update/leave/members vertically on group convo dropdown
• [ ] light gray hairline at the bottom of the group details dropdown.

Groups + Messages

• [ ] More padding above and below status messages (8 pt?)
• [ ] Attachment button should be 21x25 (will need QA here)

Onboarding

• [ ] Header 18pt Medlum, Subheader 14pt Regular
• [ ] Better alignment for everything onboarding (work with Cade)
• [ ] stretch goal: put in tutorial a la Android.

Empty States

• [ ] empty state for loading on launch in message compose should be uiEmpty with spinner in the middle of it and text "Loading contacts"
• [ ] empty state for loading on launch in message compose should be "None of your contacts have Signal.\nWhy don't you invite some". Screenshot in previous comment

attaching things

• [x] after attaching a video , sometimes the keyboard is moved below the view, this effects all views
• [ ] parallelize (somehow, at least in UI display) uploading an attachment while another is uploading

groups

• [x] group avatars broke, are not attached.

media

• [ ] file size limits

Crashes et al

• [ ] rocket emoji protocol buffer issue
• [ ] launch video player or audio, on a return the tap button disabled
• [ ] audio support is pretty flaky, needs to be more robust if we are to launch with it

navigation bar

• [x] The nav bar goes black sometimes

other

• [x] archiving group thread broken (maybe? haven't reproduced this)
• [x] make it for sure that we can't remove members from a group.
• [x] invite to signal with international number

todos for beta 1/30

• [x] update process from existing beta.... (keep keys but delete DB..) @corbett tsrecipients, tsthreads, tsinteraction deletion delete all in transaction.
• [x] empty screen finalize contacts, other empty screens (including animation) @corbett
• [x] signup flow for 4s (custom logic for scroll view for 4s @FredericJacobs (or @corbett)
• [x] push finalize @FredericJacobs
• [ ] group relation of Avatar... @FredericJacobs
• [x] critical: add in frame reset in the global after present modal view controller so that half keyboard icon never appears @corbett
• [ ] critical: call crash on incoming if not given enough time to ring

good to beta but if we can:

• [ ] check off as many 99 issues as possible @corbett
• [ ] check off as many 99 issues as possible @FredericJacobs

post beta sprint

• [ ] converse with Tyler re:Icons.

[FredericJacobs]

Good for now.