signalapp / Signal-iOS

A private messenger for iOS.
https://signal.org
GNU Affero General Public License v3.0
10.72k stars 2.99k forks source link

Notify on reactions when preview is set to .nameNoContent #5542

Closed withzombies closed 1 year ago

withzombies commented 1 year ago

First time contributor checklist

Contributor checklist

Unfortunately, testing this change isn't feasible without access to the signing key associated with the developer account and the APNS certificates.


Description

This fixes an issue where reaction notifications were not generated if you had set your notification content privacy to "Name Only". This resulted in missed responses since reactions did not generate notifications, nor were they indicated in message previews when viewed from the main screen.

Some of my contacts have started using emoji reactions for responses, meaning I've missed some responses to important messages due to my notification content setting (which was set to "Name Only").

Failure to notify recipients of responses is a bug as the UI is currently designed. The handling of reactions is ambiguous based on the options provided here: IMG_2974 (1)

With these existing controls, reactions should cause notifications in at least the first two options.

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

withzombies commented 1 year ago

Hello, is anyone going to respond to this PR?

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] commented 1 year ago

This issue has been closed due to inactivity.