signalapp / Signal-iOS

A private messenger for iOS.
https://signal.org
GNU Affero General Public License v3.0
10.72k stars 2.99k forks source link

When tapping on the "Audio" view on a reply the relevant Audio doesnt flash to indicate which one they replied to. It does on macOS #5547

Closed marcosrdz closed 1 year ago

marcosrdz commented 1 year ago

Bug description

Describe here the issue that you are experiencing.

Steps to reproduce

Actual result: Describe here what happens after you run the steps above (i.e. the buggy behaviour)

Expected result: Describe here what should happen after you run the steps above (i.e. what would be the correct behaviour)

Screenshots

Device info

Device: iDevice X

iOS version: X.Y.Z

Signal version: Z.Y

Link to debug log

d108 commented 1 year ago

highlight_recipient

@marcosrdz Does the animated gif in this reply describe the behavior you seek on iOS?

marcosrdz commented 1 year ago

That is correct

d108 commented 1 year ago

@marcosrdz Looking into this more, we can break the problem into two parts.

  1. The highlight idiom from the desktop platform does not appear on iOS.
  2. Navigation to the original message from the quoted reply preview above the input area is not implemented in iOS as on the desktop version.

Regarding what we can call a bug, fixing the missing navigation in (2) might have a better chance of getting approved because it matches existing behavior when selecting a reply in the chat list.

On the other hand, the desktop version implemented for Windows, Linux, and macOS through Electron represents a different platform. Our arguing for interface idioms to be applied equally across platforms for (1) might fall outside the scope of a bug fix.

Therefore, we can propose enabling navigation from a quoted reply preview as one step toward fixing the problem you found. The benefit we can gain is the ability to quickly navigate back to the original message context of our active reply.

Please review the animated image demonstrating a possible fix for (2) and share your thoughts on re-focusing this issue. The GIF shows the following interaction flow:

quoted reply select to go back to original message context

marcosrdz commented 1 year ago

It becomes confusing when youre responding to a voice message. If the person sent like 3 voice messages theres no way to tell which the reply is for.

d108 commented 1 year ago

@marcosrdz Your explanation makes things clearer. If we can highlight the messages, it will reduce ambiguity when the quoted replies have a non-distinguishable appearance, such as with audio.

Please review the animation shared below. Then, let's discuss the changes as proof of concept. How do you find they will address the problem?

It demonstrates the following features:

We have two separate cases for scrolling:

  1. The original message is out of view and requires scrolling to show it.
  2. The original message is wholly or partially in view. Some scrolling may occur.

There exist some additional items to resolve before a PR is possible, including:

proof of concept highlighting 2

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] commented 1 year ago

This issue has been closed due to inactivity.