signalapp / Signal-iOS

A private messenger for iOS.
https://signal.org
GNU Affero General Public License v3.0
10.72k stars 2.99k forks source link

Sharing photos from the Photos app results in reduced quality photo vs sharing from within the Signal app #5552

Closed JoelLisenby closed 1 year ago

JoelLisenby commented 1 year ago

Bug description

Sharing photos from the Photos app results in reduced quality photo vs sharing from within the Signal app.

Steps to reproduce

If you select the photo from within the Signal app instead of from the Photos app, it is a much higher resolution and quality image.

Actual result: The photo is converted to a reduced resolution, and the quality is very bad (artifacts present). 1200x1600 (1.1MB) [is shared as this]

Expected result: The photo should be higher resolution (ideally native) and crisp, not blurry with reduced quality. 2304x3072 (3.7MB) [should be this]

Device info

Device: iPhone 14 Pro

iOS version: 16.3.1

Signal version: 6.11.0.11

JoelLisenby commented 1 year ago

I'd like to add, this happens to multiple apps (I tested and confirmed it occurs both in Signal and Facebook apps.) It may be a bug in the Photos app or iOS itself, but apple support appears to be blaming the "service provider", they define as app developers. https://discussions.apple.com/thread/254671115

EvanHahn-Signal commented 1 year ago

Unfortunately, this is working as expected. Apple limits the amount of memory that we can use in the share extension, which means that we have to compress images more when they go through that path...and why Apple's apps can sidestep this problem.

I'm going to close this issue because I don't think there's anything we can do.

JoelLisenby commented 1 year ago

Thanks Evan, can you point me to the lines of code where this occurs by chance? It would be helpful if I can relay the exact functions to Apple