signalapp / Signal-iOS

A private messenger for iOS.
https://signal.org
GNU Affero General Public License v3.0
10.79k stars 3.02k forks source link

Collection picker thumbnails do not respect device scale #5592

Closed skjiisa closed 1 year ago

skjiisa commented 1 year ago

Bug description

The collection picker thumbnails do not respect device scale, leaving devices with a 2x or 3x scale to not render full-resolution thumbnails.

Steps to reproduce

Actual result: Collection thumbnails appear low resolution

Expected result: Collection thumbnails appear higher resolution

Screenshots

Collections

Signal collection Photos folder thumbnail
Signal collection Photos folder

Notice that the folder thumbnail from the Photos app is clearer despite being a smaller UI element.

Device info

Device: 2018 iPad Pro 11-inch

iOS version: 16.4.1

Signal version: 6.22.0.9

Proposed solution

I noticed this while working on a PR (#5589) and I think an easy solution would be to add an extra property to PhotoMediaSize which multiplies the dimensions by the device scale. The current property would be used for UI constraints while the new value would be used for image fetching.

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] commented 1 year ago

This issue has been closed due to inactivity.