signalapp / Signal-iOS

A private messenger for iOS.
https://signal.org
GNU Affero General Public License v3.0
10.79k stars 3.02k forks source link

remove manual imageInsets for centering icon in playButton #5626

Closed leomino closed 11 months ago

leomino commented 1 year ago

First time contributor checklist

Contributor checklist

Problem

Since the introduction of the new icon set, the play-icon is now positioned correctly in its own frame. In the past, this was not the case, so a manual code adjustment was made to fix its offset in VideoEditorView.

Proposed changes

However, with the new icon set, this code adjustment is no longer needed. Therefore, it should be removed to ensure that the new icon appears centered as intended.

Screenshot 2023-07-13 at 15 57 08 (left: before, right: after)

Note: the manual code correction was only made in VideoEditorView. Therefore no other adjustments needed to fix this issue.

stale[bot] commented 12 months ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] commented 11 months ago

This issue has been closed due to inactivity.