Tall images are obscured by iOS notch

signalapp / Signal-iOS

A private messenger for iOS.

https://signal.org

GNU Affero General Public License v3.0

10.61k stars 2.96k forks source link

Tall images are obscured by iOS notch #5635

Closed sdgluck closed 10 months ago

sdgluck commented 11 months ago

[x] I have searched open and closed issues for duplicates
[x] I am submitting a bug report for existing functionality that does not work as intended
[x] This isn't a feature request or a discussion topic

Bug description

Tall images viewed within Signal are obscured by the notch.

Steps to reproduce

send an image whose height is equal or larger than the iOS device viewport
view the image

Actual result: the top of the image is obscured by the notch

Expected result: images are displayed within the safe area of the iOS device (https://developer.apple.com/design/human-interface-guidelines/layout#)

Screenshots

Screenshots taken on an iPhone with a notch do not display the notch, so it is not possible to provide a screenshot of this behaviour.

Device info

Device: iPhone 12

iOS version: 16.5.1

Signal version: 6.33.0.9

Link to debug log

n/a

Miguel-Signal commented 11 months ago

Hi @sdgluck,

Can you please update to the latest version of Signal (v6.35) and see if this resolves the issue? Then, if the issue is still happening, could you send in new logs from this new version as well as the dimensions of the photo?

To share a debug log from Signal iOS, tap your profile Profile Avatar, Settings, Help, Submit Debug Log, Copy Link, then open this email, long-press and choose paste to paste the link.

To get the dimensions of a photo, open it in the Photos app and tap the information icon.

sdgluck commented 11 months ago

I updated to version 6.35.0.9 and the issue is still present.

The problem can be reproduced using the image below:

https://github.com/signalapp/Signal-iOS/assets/3265173/57d183ed-5e54-449d-bf7e-fb6d32aba865

Image dimensions: 756x1600

Debug logs:

https://debuglogs.org/ios/6.35.0/faf49676d8955ce9beb3782830c8abd2e5380fd214852d727ae4d43bafe0ea27.zip

Miguel-Signal commented 10 months ago

We are not able to recreate this issue on the latest Signal version (v6.40). Viewing your image renders correctly within the safe area of the screen. Can you update to the latest Signal version and let me know if it resolves the issue for you?

sdgluck commented 10 months ago

Having just updated to v6.40 as recommended, the issue is no longer present. Tall images now display within the safe area. Thank you. I will close this issue now.