signalapp / Signal-iOS

A private messenger for iOS.
https://signal.org
GNU Affero General Public License v3.0
10.61k stars 2.96k forks source link

Link containing two #s is not clickable #5675

Open gabrc52 opened 9 months ago

gabrc52 commented 9 months ago

Bug description

Describe here the issue that you are experiencing.

Steps to reproduce

Actual result: Link is not clickable

Expected result: Link is clickable

Screenshots

image

Device info

Device: iPhone 6s

iOS version: 15.7.8

Signal version: 6.43.0.10

Link to debug log

https://debuglogs.org/ios/6.43.0/fc74a0034212a27cc4d4c24f0a3cd9b4e1d1158c84c3a2a14d1afd78f16a8885.zip

TheBlckbird commented 9 months ago

It doesn’t seem to be a Signal-specific problem. Signal uses a link detector embedded in UIKit/Swift or something:
NSTextCheckingResult.CheckingType.link.rawValue: https://github.com/signalapp/Signal-iOS/blob/2d6fee16cd92cedf20eafaa3908df0be32d4e9b3/Signal/src/util/DisplayableText.swift#L129

(If this is wrong, please correct me)

Miguel-Signal commented 8 months ago

Hi @gabrc52,

Is there a valid URL with two #s that does not linktify? The one provided is just an example domain.

TheBlckbird commented 8 months ago

This URL is valid, but it's uncommon.

gabrc52 commented 8 months ago

Yes, links to Matrix rooms have this format: https://matrix.to/#/#matrix:matrix.org

stale[bot] commented 5 months ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

TheBlckbird commented 5 months ago

Don‘t close

stale[bot] commented 2 months ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

gabrc52 commented 2 months ago

Unstale