search

signalapp / Signal-iOS

A private messenger for iOS.
https://signal.org
GNU Affero General Public License v3.0
10.78k stars 3.02k forks source link

Crash when attempting to link device #5705

Open fulldecent opened 10 months ago

fulldecent commented 10 months ago

Bug description

Describe here the issue that you are experiencing.

Steps to reproduce

I am experiencing this crash also:

  1. Get a iPhone (13)
  2. turn on lockdown mode
  3. Install Signal, open it
  4. say no on popups for: notifications, local network, contacts
  5. Get a mac (M1 MBP, 2021)
  6. turn on lockdown mode
  7. Install Signal
  8. Open Signal, get QR code
  9. Scan QR code from camera app on iPhone
  10. It opens Signal
  11. Signal says it needs a camera to link a device (even though you already deep linked into Signal)
  12. say no on popup for camera
  13. go to settings app to turn on camera
  14. scan qr code again, it opens signal app
  15. signal says it wants to scan qr code
  16. click to scan qr code from inside signal app
  17. say no to popup for microphone

Expected outcome:

  1. Camera access is not required for Signal to link a device (using a QR scanned by operating system and deep linking to Signal)
  2. If you do want to allow camera access, linking a device from inside the app should link the device

Actual outcome:

  1. Deep links do not work
  2. Unnecessary permissions are requested many times inside the app
  3. Crashes and linking devices is not possible
  4. iOS app crashes after step 17

Screenshots

Device info

Device:

  1. iPhone 13
  2. MacBook Pro 14-inch, 2021

iOS version:

  1. 16.7
  2. 14.0 (23A344)

Signal version:

The latest version on iOS app store as of 223-11-16.

Link to debug log

Email sent with subject: iOS Crash Log: GitHub issue #5705

And filename Signal-2023-11-16-184844.ips

iakat commented 10 months ago

Reproduced. iPhone 15 Pro running 17.1.1 and MacBook Air M2 running 14.1.1

bmfores commented 10 months ago

tried this on iPhone 13 Pro on 17.1.1, and Macbook Air M1 2020 running 14.0. my app also crashes.

prashand commented 10 months ago

iPhone 6s Plus, Software Version = 15.8(19H370) Signal iOS version = 6.50.1.0 Signal Mac Desktop app version = 6.39.1 production (Apple silicon)

Mobile app crashes immediately after scanning the QR code from the desktop app

dave7280 commented 10 months ago

Same here. ip 15 pro. 17.1.1 Signal iOS version = 6.50.1.0

It is not possible to link any 3rd party apps. Plz fix.

Update: Thanks for quick answer and the workaround :)

Miguel-Signal commented 10 months ago

The bug fix is being worked on. In the meantime, there is a workaround.

Go into Signal Settings and enable a PIN. You should be able to link a device afterwards. You can disable the PIN afterwards if you'd like.

r6t commented 10 months ago

Signal iOS 6.50.1.0 on iPhone 15 Pro Max signal-desktop on NixOS, both the latest Flathub and Nixpkgs versions

Mobile app crashes immediately upon scanning QR code to link. Confirming the PIN workaround was successful.

yashbedi commented 9 months ago

Hey is this issue fixed I would like to work on this, Thanks.

TheExtravagantHobo commented 9 months ago

Pin workaround doesn't work for me. Tried to add Signal to an iPad mini 5th (MUXH2LL/A) running iPadOS 17.2. Signal fresh download. Scanned the QR from iPhone 13 Pro (MLR63LL/A) running iOS 17.2.1, Signal 6.54.0.8. Both on same wifi.

Scanning the QR with the phone (which always had the Pin on) immediately crashes the iPad app.

Removed Pin -- same result Re-added Pin -- same result

? Thanks! Happy New Year.

Miguel-Signal commented 8 months ago

Hi @TheExtravagantHobo, could you please email support@signal.org with debug logs from both the phone and iPad, as well as a crash report from the iPad?

To share a debug log from your iPhone, tap your profile, Settings, Help, Submit Debug Log, Copy Link.

To share debug logs from an unlinked iPad, quit then re-open Signal and tap 8 times on an empty area of the screen. You should see a prompt to submit debug logs.

Here's information on how to share a crash report:

Go to iOS Settings > Privacy (& Security) > Analytics (& Improvements) > Analytics Data. Locate and select the .ips crash log for Signal. The logs will likely be named in the format: Signal(DateTime)(DeviceName).ips, but please also ignore logs that have 'wakeups' in the file name. Tap the Share icon in the top corner.

TheExtravagantHobo commented 8 months ago

There’s no data on the iPhone for Signal. It doesn’t crash. The iPad shows up in its linked devices at the same time the iPad crashes. The iPad is then not linked, even though it shows up in the Signal app as a linked device, and you can add more copies of it to linked devices. Here’s a fresh one:



Respectfully; Alex Sonne 808-800-1150 @.***

On Jan 17, 2024, at 9:25 PM, Miguel-Signal @.***> wrote:

Hi @TheExtravagantHobo https://github.com/TheExtravagantHobo, could you please email @. @.> with debug logs from both the phone and iPad, as well as a crash report from the iPad?

To share a debug log from your iPhone, tap your profile, Settings, Help, Submit Debug Log, Copy Link.

To share debug logs from an unlinked iPad, quit then re-open Signal and tap 8 times on an empty area of the screen. You should see a prompt to submit debug logs.

Here's information on how to share a crash report:

Go to iOS Settings > Privacy (& Security) > Analytics (& Improvements) > Analytics Data. Locate and select the .ips crash log for Signal. The logs will likely be named in the format: Signal(DateTime)(DeviceName).ips, but please also ignore logs that have 'wakeups' in the file name. Tap the Share icon in the top corner.

— Reply to this email directly, view it on GitHub https://github.com/signalapp/Signal-iOS/issues/5705#issuecomment-1897665830, or unsubscribe https://github.com/notifications/unsubscribe-auth/BFFBWW6JDW26RKXX6AUK3PLYPCB2XAVCNFSM6AAAAAA7P5FUE2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOJXGY3DKOBTGA. You are receiving this because you were mentioned.

jc-frosty commented 7 months ago

Should I create a new issue if my iPad signal app crashes after hitting ‘finish linking’ and neither of my devices have lockdown mode on. I have the pin on. I have had the iPad app linked before though I don’t know if inactivity(happens to the Mac app a lot) or an update unlinked them.

Miguel-Signal commented 7 months ago

@jc-frosty 30 days of inactivity will unlink a secondary device wether it's an iPad or Desktop.

Could you please write into support@signal.org so we can troubleshoot this further?

simonholgate commented 7 months ago

+1 on @jc-frosty comment. iPad unlinked (possibly due to inactivity).

Tried re linking iPad with Android (Pixel 8). iPad shows up as linked on the phone but iPad app crashes immediately after linking and begins linking process again after restart.

simonholgate commented 7 months ago

As a quick update - deleting the ipad app and reinstalling allowed me to relink.