signalapp / Signal-iOS

A private messenger for iOS.
https://signal.org
GNU Affero General Public License v3.0
10.6k stars 2.95k forks source link

Textinput hidden by virtual keyboard when scaling font size systemwide #5708

Closed oldnick1818 closed 6 months ago

oldnick1818 commented 7 months ago

Bug description

The "autoscroll" function when typing a message isn't funtioning correctly when the font size is increased systemwide in the ios settings app. Exact behavior: The last line of a message you are writing gets covered by the virtual keyboard. I believe the autoscrolling behaves like the fonts were not increased and therefore scrolls "to late" to the line you are actually writing. The bug behavior seems to be also related to the length of the words you are typing. It doesn't appear, when the words a very short

Steps to reproduce

Actual result: the last line of the message you are writing gets hidden by the virtual keyboard

Expected result: the last line of the message you are writing should be seen as otherwise you don't see what you are writing at the moment.

Screenshots

E5F30C04-0437-43EE-BA53-CB01B450F8C5 3FAA3A03-667D-4926-A02A-6236EAD38003

Device info

Device: iPhone SE 2020

iOS version: 17.1.1

Signal version: 60.50.0.13

Link to debug log

[ https://debuglogs.org/ios/6.50.0/ecbd89f62ac7e37afb018fc8e0e1e9287354b3e4068e5c9aa8f80dc529631df6.zip

oldnick1818 commented 7 months ago

I should add that it is not possibe to scroll down to the line where the cursor is, as it scrolls back up immediately in the unfortunate position shown in the screenshots above.

Miguel-Signal commented 7 months ago

Hi @oldnick1818, could you please email support@signal.org with a link to your debug logs and reference this Github issue?

To share a debug log from Signal iOS, tap your profile, Settings, Help, Submit Debug Log, Copy Link.

Janikson9 commented 7 months ago

There was a slight improvement in the course of the update. However, the problem still occurs occasionally with some chats.

I have already written to signal support (with debug log) several times. So far without success.

Device: iPhone 15 2023 iOS: 17.1.1.

https://github.com/signalapp/Signal-iOS/assets/152014058/3628fd63-47b7-4785-9784-b193aaf2ee44

koch86 commented 7 months ago

I can confirm the issue with iPhone 15 Pro / iOS 17.1.1

IMG_0306

I did not change the text size - so for me the issue occurs with default setting. Issue was first observed quite some versions ago (also with iOS 16).

IMG_0309

meyermarcel commented 7 months ago

This issue still exists for me as well.

I have the following versions:

iOS 17.1.2 iPhone SE 2nd Gen (A2296) Signal 6.51

I have these preferences that deviate from the default view preferences in iOS to allow better readability for my eyes:

IMG_4713 IMG_4714

I reproduced this bug by inserting

Lorem ipsum dolor sit amet, consetetur sadipscing elitr, sed diam nonumy eirmod tempor invidunt ut labore et dolore magna aliquyam erat, sed diam voluptua. At vero eos et accusam et justo duo dolores et ea rebum. Stet clita kasd gubergren, no sea takimata sanctus est Lorem ipsum dolor sit amet. Lorem ipsum dolor sit amet, consetetur sadipscing elitr, sed diam nonumy eirmod tempor invidunt ut labore et dolore magna aliquyam erat, sed diam voluptua. At vero eos et accusam et justo duo dolores et ea rebum. Stet clita kasd gubergren, no sea takimata sanctus est Lorem ipsum dolor sit amet.

in a note to myself and deleting the last words:

https://github.com/signalapp/Signal-iOS/assets/3398801/fe830e58-29e5-49f4-9f9f-8a17290b546a

Miguel-Signal commented 7 months ago

Would anyone willing to try out the latest Signal Beta (version 6.52.0.8) install it and tell me if it fixes this issue?

Follow steps from the support page here to join the iOS Beta: https://support.signal.org/hc/articles/360007318471

meyermarcel commented 7 months ago

Would anyone willing to try out the latest Signal Beta (version 6.52.0.8) install it and tell me if it fixes this issue?

Follow steps from the support page here to join the iOS Beta: https://support.signal.org/hc/articles/360007318471

I installed the iOS Signal beta (Preferences -> Help -> Version -> 6.52.0.8) and I get the exact same behaviour with my zoomed preferences and the lorem ipsum... reproducer shown in the video.

hembeh commented 7 months ago

Can confirm that this behavior is present on iPhone 15 pro max 17.2 running signal 2.2. The issue is there since iOS 15 and is quite annoying.

Miguel-Signal commented 7 months ago

We've just released Beta version 6.53.0.5, and would appreciate some feedback on this version!

meyermarcel commented 7 months ago

We've just released Beta version 6.53.0.5, and would appreciate some feedback on this version!

The bug seems to be fixed with Signal 6.53.0.5 and these reproducers:

Maybe an other reproducer produces a different result.

Miguel-Signal commented 6 months ago

This issue should now be resolved with the production version 6.53!

https://apps.apple.com/us/app/signal-private-messenger/id874139669

meyermarcel commented 6 months ago

Thanks for fixing this bug :)

There might already be a self-referential German word to describe “German words that are so big they won’t fit on a single line,” but we fixed the “lost cursor” bug that was affecting some long German words on iOS 17.

I don't believe that this bug only affected german users. I think this was a global bug. But I have no proof and I think that the version description was done with diligence.

At the end it is fixed and that's a good thing 🎉

oldnick1818 commented 6 months ago

Great thanks a lot!! The bug was rly annoying and fixing it improved my daily experience with the app a lot 🥳